Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: remove bottle :unneeded #79938

Closed
wants to merge 2 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jun 24, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Separate PR, split from #79448.

@Moisan Moisan added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 24, 2021
@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue legacy Relates to a versioned @ formula labels Jun 24, 2021
@cho-m
Copy link
Member

cho-m commented Jun 24, 2021

As expected, we hit the same "ARM vs Intel" diff as solr #79751 (comment)

--- a/[email protected]/7.7.3_1/libexec/solr
+++ b/[email protected]/7.7.3_1/libexec/solr
@@ -25,7 +25,7 @@
 # ./
 # $HOME/.solr.in.sh
 # /usr/share/solr
-# /usr/local/share/solr
+# @@HOMEBREW_PREFIX@@/share/solr
 # /var/solr/
 # /opt/solr
 #
@@ -83,7 +83,7 @@ if [ -z "$SOLR_INCLUDE" ]; then
   for include in "`dirname "$0"`/solr.in.sh" \
                "$HOME/.solr.in.sh" \
                /usr/share/solr/solr.in.sh \
-               /usr/local/share/solr/solr.in.sh \
+               @@HOMEBREW_PREFIX@@/share/solr/solr.in.sh \
                /etc/default/solr.in.sh \
                /opt/solr/solr.in.sh; do
     if [ -r "$include" ]; then

@carlocab
Copy link
Member

We definitely want to change that one.

@MikeMcQuaid
Copy link
Member

Same thing in #79751.

@BrewTestBot
Copy link
Member

:shipit: @MikeMcQuaid has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue legacy Relates to a versioned @ formula outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants