Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couchpotatoserver: remove bottle :unneeded and use service #80078

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Extracted from #79995 to independently check on audit failure.

@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Jun 26, 2021
@cho-m cho-m added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 26, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
@cho-m
Copy link
Member Author

cho-m commented Jun 27, 2021

I think we can bottle this once #79366 is merged, which will remove the plist.

@SMillerDev Is the service block bulk PR close to merge?

If not, it may be worth just extract changes for couchpotatoserver into this PR since we are close to finishing up #75943

@SMillerDev
Copy link
Member

Go for it, I'll rebase.

@cho-m cho-m force-pushed the couchpotatoserver-bottle branch from 00defd8 to e790478 Compare June 27, 2021 21:52
@cho-m cho-m changed the title couchpotatoserver: remove bottle :unneeded couchpotatoserver: remove bottle :unneeded and use service Jun 27, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the couchpotatoserver-bottle branch June 27, 2021 23:12
@carlocab
Copy link
Member

Looks like this ships a pre-compiled unrar in libexec/libs/unrar:

❯ file couchpotatoserver/3.0.1/libexec/libs/unrar2/unrar
couchpotatoserver/3.0.1/libexec/libs/unrar2/unrar: Mach-O executable i386

We should just get rid of that. It doesn't even work on any system we support. Indeed:

❯ ./couchpotatoserver/3.0.1/libexec/libs/unrar2/unrar
zsh: bad CPU type in executable: ./couchpotatoserver/3.0.1/libexec/libs/unrar2/unrar

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. deprecated license Formula uses a deprecated SPDX license which should be updated outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants