Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2p: remove bottle :unneeded #80106

Closed
wants to merge 1 commit into from
Closed

i2p: remove bottle :unneeded #80106

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Extract from #79998

@cho-m cho-m added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 26, 2021
@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue missing license Formula has a missing license which should be added labels Jun 26, 2021
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jun 27, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
@Moisan
Copy link
Member

Moisan commented Jun 27, 2021

No bottle is the same.

> sha256sum *.tar.gz
91ac9fbb2404651738e12dfdb83cdc52579447b179d0866e4a47edba8cb6c8a4  i2p--0.9.50.arm64_big_sur.bottle.tar.gz
99cd48d4a4af5c0aca367cd0155473059dc41aaa92ee55ded8b3e91e3d65a6e9  i2p--0.9.50.big_sur.bottle.tar.gz
1494be1975d2011c1cbdf030c723340bbe91c20a31b44d0ac802791226d8d8bc  i2p--0.9.50.catalina.bottle.tar.gz
ece392199586ca726a9f1de563982be8650b55db82c26b6a2dd66b82cab70f6e  i2p--0.9.50.mojave.bottle.tar.gz

@cho-m
Copy link
Member Author

cho-m commented Jun 27, 2021

It looks like the installer will construct JAR files, which diff on modified timestamps and perhaps some other system build details.

java -jar i2pinstall_#{version}.jar -options path.conf -language eng

e.g.

│ ├── i2p/0.9.50/libexec/Uninstaller/uninstaller.jar
│ │┄ Archive contents identical but files differ, possibly due to different compression levels. Falling back to binary comparison.
│ │ ├── zipinfo -v {}
│ │ │ @@ -35586,15 +35586,15 @@
│ │ │    version of encoding software:                   2.0
│ │ │    minimum file system compatibility required:     MS-DOS, OS/2 or NT FAT
│ │ │    minimum software version required to extract:   2.0
│ │ │    compression method:                             deflated
│ │ │    compression sub-type (deflation):               normal
│ │ │    file security status:                           not encrypted
│ │ │    extended local header:                          yes
│ │ │ -  file last modified on (DOS date/time):          2021 Jun 27 05:25:46
│ │ │ +  file last modified on (DOS date/time):          2021 Jun 27 05:25:44

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the i2p-bottle branch June 27, 2021 23:13
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue missing license Formula has a missing license which should be added outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants