Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idnits: remove bottle :unneeded #80107

Closed
wants to merge 1 commit into from
Closed

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Extracted from #79998

@cho-m cho-m added bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. labels Jun 26, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
@cho-m
Copy link
Member Author

cho-m commented Jun 27, 2021

Same failure as previous attempt #76129, which I think is due to the draft we are using for testcase.

EDIT: Looks like it takes too long to process and times out on CI. I was able to get test to run locally and using website UI.

Will try a few other drafts to see if they work better.

@cho-m cho-m force-pushed the idnits-bottle branch 2 times, most recently from cf57293 to a131ec6 Compare June 28, 2021 01:33
@cho-m cho-m added the help wanted Task(s) needing PRs from the community or maintainers label Jun 28, 2021
@nandahkrishna
Copy link
Member

The draft I've used now doesn't take as much time as the previous one (perhaps because it's shorter), but the bulk of the time taken for the test is to download and setup the ~/.idnits directory.

@nandahkrishna nandahkrishna added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers labels Jun 28, 2021
@BrewTestBot
Copy link
Member

:shipit: @nandahkrishna has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
@cho-m cho-m deleted the idnits-bottle branch April 24, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants