Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

growly: remove bottle :unneeded #80151

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 27, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Didn't realize we were also removing bottle :unneeded from disabled formulae.

I should have done it in #80146, but for now using separate PR as follow-up.

Not sure if this is a syntax-only change or if actual bottles are built, so will let CI run with force-arm in case.

@cho-m cho-m added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 27, 2021
@BrewTestBot BrewTestBot added formula disabled Formula disabled missing license Formula has a missing license which should be added labels Jun 27, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
@nandahkrishna
Copy link
Member

Not sure if this is a syntax-only change or if actual bottles are built

I think bottles aren't built for disabled formulae, the CI run confirms this as well – so it's syntax only. Not sure if we actually intend to build bottles, but there would be no point since they're disabled and can't be installed.

@cho-m
Copy link
Member Author

cho-m commented Jun 27, 2021

@nandahkrishna Sounds like what I was expecting. Probably can directly merge changes.
Should be similar to how other disable formulae ended up as part of bulk PRs.

@nandahkrishna nandahkrishna merged commit db58e1f into Homebrew:master Jun 27, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
@cho-m cho-m deleted the growly-remove-unneeded branch April 24, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. formula disabled Formula disabled missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants