Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skinny: remove bottle :unneeded #80152

Closed
wants to merge 1 commit into from
Closed

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 27, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 27, 2021
@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Jun 27, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jun 27, 2021
@nandahkrishna
Copy link
Member

Relevant parts of the diffoscope output:

│ ├── skinny/3.1.0/libexec/skinny
│ │ @@ -8,15 +8,15 @@
│ │  chmod +x ${sbt_path}
│ │  chmod +x ${sbt_debug_path}
│ │
│ │  # prepared deps
│ │  if [ -d "${script_dir}/ivy2" ]; then
│ │    mkdir -p $HOME/.ivy2/cache/
│ │    cp -prn ${script_dir}/ivy2/cache/* $HOME/.ivy2/cache/.
│ │ -  if [[ ! "$0" =~ /usr/local/Cellar/skinny/.* ]]; then
│ │ +  if [[ ! "$0" =~ @@HOMEBREW_CELLAR@@/skinny/.* ]]; then
│ │        rm -rf ${script_dir}/ivy2
│ │    fi
│ │  fi
│ │
│ │  function verify_skinny_project() {
│ │    if [ "${current_project}" == "" ]; then
│ │      echo "Skinny application not found here!"
│ ├── skinny/3.1.0/libexec/skinny-blank-app/skinny
│ │ @@ -8,15 +8,15 @@
│ │  chmod +x ${sbt_path}
│ │  chmod +x ${sbt_debug_path}
│ │
│ │  # prepared deps
│ │  if [ -d "${script_dir}/ivy2" ]; then
│ │    mkdir -p $HOME/.ivy2/cache/
│ │    cp -prn ${script_dir}/ivy2/cache/* $HOME/.ivy2/cache/.
│ │ -  if [[ ! "$0" =~ /usr/local/Cellar/skinny/.* ]]; then
│ │ +  if [[ ! "$0" =~ @@HOMEBREW_CELLAR@@/skinny/.* ]]; then
│ │        rm -rf ${script_dir}/ivy2
│ │    fi
│ │  fi
│ │
│ │  function verify_skinny_project() {
│ │    if [ "${current_project}" == "" ]; then
│ │      echo "Skinny application not found here!"

I think inreplace would be apt here, and we could probably handle it here since it's a separate PR.

@cho-m cho-m removed the ready to merge PR can be merged once CI is green label Jun 27, 2021
@nandahkrishna
Copy link
Member

3599c215671ecb68ec4f067b69d130635d3b10fb3e28c562641683886ba02d13 on all 4 platforms.

@nandahkrishna nandahkrishna added the ready to merge PR can be merged once CI is green label Jun 27, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the skinny-bottle branch June 27, 2021 20:08
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants