Import formulae from homebrew/games (take two). #9753

MikeMcQuaid · 2017-02-08T10:46:06Z

Try to import the formulae that failed to build on Sierra in #9685.

@mistydemeo @tomyun I'll leave this open for about a week after which things that still can't build with Clang on Sierra will be deleted from homebrew/games rather than imported.

@tomyun I'll give you write access to my fork and @mistydemeo should already have it.

ilovezfs · 2017-02-08T14:02:29Z

mistydemeo · 2017-02-10T23:54:06Z

@mistydemeo @tomyun I'll leave this open for about a week after which things that still can't build with Clang on Sierra will be deleted from homebrew/games rather than imported.

As mentioned in the previous PR, I've been at a conference and haven't had a chance to look before now - mind making it a week today (18th AEST)?

mistydemeo · 2017-02-11T00:32:48Z

Raine itself isn't failing; what's failing is sdl_image --universal, because we removed webp's universal option in 2e69f2c.

mistydemeo · 2017-02-11T00:35:45Z

openmsx fails due to clang crashing, which is an Apple/clang bug rather than an openmsx bug:

Compiling video/scalers/ScalerFactory.cc...
clang: error: unable to execute command: Floating point exception: 8
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
clang: note: diagnostic msg: PLEASE submit a bug report to http://developer.apple.com/bugreporter/ and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg: 
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/HQ3xScaler-9b2370.cpp
clang: note: diagnostic msg: /tmp/HQ3xScaler-9b2370.sh
clang: note: diagnostic msg: 

********************

Submitted as rdar://30475877.

mistydemeo · 2017-02-11T00:55:08Z

The arx-libertatis bug appears to have already been fixed upstream: arx/ArxLibertatis@39fb9a0

ilovezfs · 2017-02-11T01:01:04Z

@mistydemeo right ... but still would need an old CMake to build (or more patch(es) from HEAD), and even then once it built, it failed to launch in my 10.12 vm (could be because it's a vm, but I didn't investigate further given the CMake trouble).

mistydemeo · 2017-02-11T01:53:00Z

HEAD launches fine for me, after some testing; I think it likely only fails to launch in a VM.

ilovezfs · 2017-02-11T01:55:32Z

Neat! I wonder if they'd be willing to make a new tag.

ilovezfs · 2017-02-11T02:01:05Z

Raine itself isn't failing; what's failing is sdl_image --universal, because we removed webp's universal option in 2e69f2c.

That's a show stopper since we're removing all 32-bit and universal options, except the ones used by wine, and those will also be removed as soon as they've all been vendored into the wine formula.

mistydemeo · 2017-02-11T11:22:50Z

That's a show stopper since we're removing all 32-bit and universal options, except the ones used by wine, and those will also be removed as soon as they've all been vendored into the wine formula.

My understanding is that key portions of Raine are written in 32-bit ASM, and it can't be built as 64-bit at all.

MikeMcQuaid · 2017-02-11T15:21:14Z

@mistydemeo We can always remove and re-add these so would rather if we stuck to a week here so the tap migration process can continue. Sounds like there's at least a few (if not all remaining) that we're not going to be able to realistically get fixed by next week so delete and re-add is probably their best bet.

ilovezfs · 2017-02-11T16:06:40Z

openmsx fails due to clang crashing, which is an Apple/clang bug rather than an openmsx bug:

it compiles with ENV.O0

mistydemeo · 2017-02-12T00:19:27Z

it compiles with ENV.O0

Sounds like a good workaround.

@MikeMcQuaid Do you want me to add commits to this branch, or submit a PR against the branch?

We can always remove and re-add these so would rather if we stuck to a week here so the tap migration process can continue.

A week is fine, I'd just rather it's a week from when I started looking at it!

mistydemeo · 2017-02-12T01:43:45Z

Pushed a few changes:

arx-libertatis: fix stable build by backporting a few changes
arx-libertatis: add HEAD
openmsx: use -O0 to work around clang bug

ilovezfs · 2017-02-12T01:51:06Z

Formula/arx-libertatis.rb

+
+      # Version parsing is broken in the current stable; fixed upstream.
+      # This hardcodes the current version based on data from VERSION.
+      inreplace "src/core/Version.cpp.in" do |s|


These version issues are what using the old CMake addressed, but hard-coding them temporarily instead of vendoring the "correct" CMake seems fine to me.

Yeah, given that this will be fixed in the next stable version, I think some minimal hardcoding is probably best.

ilovezfs · 2017-02-12T01:53:00Z

Formula/arx-libertatis.rb

@@ -25,6 +25,23 @@ class ArxLibertatis < Formula
  def install
    args = std_cmake_args

+    # The patches for these aren't straightforward to backport because of
+    # other changes; these minimal inreplaces get it building.
+    # HEAD is fine, and the next stable release will contain these changes.


The last stable release was in 2013. It would be good to get some kind of commitment out of upstream to at least create a new tag at some point soon.

Agreed. Development is clearly very active, but with four years between releases I would really like to see another.

Mind creating "Can haz tag plz?" issue so we can at least track where they stand on this?

ilovezfs · 2017-02-12T02:11:31Z

Formula/openmsx.rb

@@ -21,6 +21,10 @@ class Openmsx < Formula
  end

  def install
+    # Fixes a clang crash; this is an LLVM/Apple bug, not an openmsx bug
+    # https://github.com/Homebrew/homebrew-core/pull/9753


maybe also add the rdar://30475877 reference?

mistydemeo · 2017-02-12T02:13:35Z

simutrans is failing because of QTKit:

sound/core-audio_sound.mm:12:9: fatal error: 'QTKit/QTMovie.h' file not found
#import <QTKit/QTMovie.h>
        ^

ilovezfs · 2017-02-12T02:15:13Z

simutrans is failing because of QTKit:

Indeed. So the best we could is an or_later bottle, but I think it's probably best to nix the formula.

mistydemeo · 2017-02-12T02:26:38Z

The two files using QTKit are very small - I'll see if I can work up a patch to port to AVFoundation.

ilovezfs · 2017-02-12T02:27:27Z

The two files using QTKit are very small - I'll see if I can work up a patch to port to AVFoundation.

👍

ilovezfs · 2017-02-12T02:59:48Z

@mistydemeo note it's also the same situation for magnetix:

In file included from /tmp/magnetix-20170211-88069-107zbbw/magnetiX_src/MXFSTableView.m:36:
In file included from /tmp/magnetix-20170211-88069-107zbbw/magnetiX_src/MXFSController.h:36:
/tmp/magnetix-20170211-88069-107zbbw/magnetiX_src/MagneticController.h:36:9: fatal error: 
      'QTKit/QTMovie.h' file not found
#import <QTKit/QTMovie.h>
        ^
1 error generated.

mistydemeo · 2017-02-12T03:50:29Z

I guess this means I have to install Xcode. :(

mistydemeo · 2017-02-12T05:49:00Z

Simutrans patch finished, and posted here: http://forum.simutrans.com/index.php?topic=16675.new#new

ilovezfs · 2017-02-12T05:59:46Z

Nice work!

mistydemeo · 2017-02-12T07:00:19Z

Ported magnetiX - branch here: https://github.com/mistydemeo/magnetiX/tree/avfoundation I've emailed the developer with the patch.

ilovezfs · 2017-02-12T07:02:46Z

Nice!

So looks like raine will be the only casualty?

mistydemeo · 2017-02-12T07:02:52Z

With Raine, if we're not willing to accept a version with vendored dependencies, I'll migrate it into my own tap with those changes.

ilovezfs · 2017-02-12T07:08:08Z

The analytics show only 13 installs of raine since July, so I'm not sure it's worth the effort, but that's up to you.

mistydemeo · 2017-02-12T07:09:13Z

It's a nice bit of emulation history. Raine was a big deal in the late 90s! I'm willing to put in the effort for a little nostalgia.

ilovezfs · 2017-02-12T08:44:26Z

Formula/magnetix.rb

+  # Port audio code from QTKit to AVFoundation
+  # Required since 10.12 SDK no longer includes QTKit.
+  # Submitted by email to the developer.
+  patch do


Probably should scope this to if DevelopmentTools.clang_build_version >= 800, no?

Given it's a major patch, I'd rather not end up shipping two different versions of the audio code - would make support easier if we're only supporting one version.

@mistydemeo as you may have guessed, I'm just anticipating what @MikeMcQuaid will/would/may say here hehe

ilovezfs · 2017-02-12T08:44:38Z

Formula/simutrans.rb

+    # Port Mac audio code from QTKit to AVFoundation
+    # Required since 10.12 SDK no longer includes QTKit.
+    # Submitted upstream: http://forum.simutrans.com/index.php?topic=16675.0
+    patch do


MikeMcQuaid · 2017-02-12T13:16:06Z

Wow, great work @mistydemeo and @ilovezfs 💖

With Raine, if we're not willing to accept a version with vendored dependencies

@mistydemeo I'd be happy to accept the version with vendored dependencies 👍 . I don't have a problem with formulae using universal internally if they need it, just the proliferation of universal options/builds.

mistydemeo · 2017-02-14T10:15:48Z

Pushed an update. The vendored dependencies all work at this point, but raine itself is having a little trouble finding them.

ilovezfs · 2017-02-14T10:17:15Z

Formula/raine.rb

+        end
+
+        args = configure_args(r.name)
+        args << "--prefix=#{libexec}"


can they not be built statically instead and installed only in the buildpath?

I gave it a shot, but SDL_image isn't building: https://gist.github.com/fc4f62f12ad00ae68333b4e8c5db6fb0

ilovezfs · 2017-02-17T12:31:55Z

Formula/raine.rb

+    ENV.prepend "PATH", "#{libexec}/bin", File::PATH_SEPARATOR
+    ENV.append_to_cflags "-I#{libexec}/include"
+    ENV.append "LDFLAGS", "-L#{libexec}/lib"
+    ENV.prepend "PKG_CONFIG_PATH", "#{libexec}/lib/pkgconfig", File::PATH_SEPARATOR


This seems highly unusual. Do we have a brew bug?

ENV.prepend_path and ENV.append_path silently do nothing if the passed directory doesn't exist, which it won't yet in this circumstance. I could also have used prepend_create_path instead of forcing the prepend.

Yes, please either use ENV.prepend_create_path or defer calling ENV.prepend_path until the directory actually exists.

MikeMcQuaid · 2017-02-17T21:32:49Z

mind making it a week today (18th AEST)?

This has rolled by and given it's still not building and wouldn't pass our notability requirements for a new formula I think it's worth punting on this. Still pretty good that all but one of the homebrew/games formulae has made it in, though.

mistydemeo · 2017-02-17T23:44:20Z

Sorry for not commenting. I've pushed a working build for a dynamically-built Raine, and I'm 95% to a statically-built one. I'm testing a build now.

mistydemeo · 2017-02-18T00:24:08Z

Pushed a static formula.

mistydemeo · 2017-02-18T01:25:40Z

The only thing broken is linking against the system libbIp2.

mistydemeo · 2017-02-18T01:50:52Z

Build works. I'll update the audit warnings.

Wrt notability, Raine has been around since the 90s; the move to GitHub is a recent one.

mistydemeo · 2017-02-18T11:10:40Z

Merged!

ilovezfs · 2017-02-18T11:23:56Z

🎊

MikeMcQuaid · 2017-02-19T16:12:40Z

Nice work both of you 🎉!

ilovezfs reviewed Feb 12, 2017

View reviewed changes

This was referenced Feb 12, 2017

Migrate simutrans from homebrew-games #9880

Closed

Migrate MagnetiX from homebrew-games #9881

Closed

arx-libertatis: migrate from homebrew-games #9883

Closed

MikeMcQuaid and others added 3 commits February 12, 2017 15:47

raine: import from homebrew/games.

1d0d0b7

wip raine

eadb04a

wip raine

8821521

ilovezfs reviewed Feb 14, 2017

View reviewed changes

mistydemeo added 2 commits February 17, 2017 23:27

Fix setting PATHs

4e3b410

Make sure CFLAGS and LDFLAGS make it through

229614b

ilovezfs reviewed Feb 17, 2017

View reviewed changes

raine: disable modplug

6d91911

mistydemeo and others added 2 commits February 18, 2017 11:38

Build and link libraries statically

60b2ec6

Fix bzip library name

7fa8fe0

Fix bzip2 (for real?)

642ace6

Fix audit warnings

477364d

mistydemeo closed this Feb 18, 2017

MikeMcQuaid deleted the homebrew-games-import-two branch February 19, 2017 16:12

Homebrew locked and limited conversation to collaborators May 4, 2018

Import formulae from homebrew/games (take two). #9753

Import formulae from homebrew/games (take two). #9753

Conversation

MikeMcQuaid commented Feb 8, 2017

ilovezfs commented Feb 8, 2017 • edited Loading

mistydemeo commented Feb 10, 2017

mistydemeo commented Feb 11, 2017

mistydemeo commented Feb 11, 2017 • edited Loading

mistydemeo commented Feb 11, 2017

ilovezfs commented Feb 11, 2017 • edited Loading

mistydemeo commented Feb 11, 2017

ilovezfs commented Feb 11, 2017

ilovezfs commented Feb 11, 2017

mistydemeo commented Feb 11, 2017

MikeMcQuaid commented Feb 11, 2017

ilovezfs commented Feb 11, 2017

mistydemeo commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mistydemeo commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

ilovezfs commented Feb 12, 2017

mistydemeo commented Feb 12, 2017

Choose a reason for hiding this comment

mistydemeo Feb 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeMcQuaid commented Feb 12, 2017

mistydemeo commented Feb 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeMcQuaid commented Feb 17, 2017

mistydemeo commented Feb 17, 2017

mistydemeo commented Feb 18, 2017

mistydemeo commented Feb 18, 2017

mistydemeo commented Feb 18, 2017

mistydemeo commented Feb 18, 2017

ilovezfs commented Feb 18, 2017

MikeMcQuaid commented Feb 19, 2017

ilovezfs commented Feb 8, 2017 •

edited

Loading

mistydemeo commented Feb 11, 2017 •

edited

Loading

ilovezfs commented Feb 11, 2017 •

edited

Loading

mistydemeo Feb 12, 2017 •

edited

Loading