Migrate OpenMSX from homebrew-games #9882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
reviewed
Feb 12, 2017
Formula/openmsx.rb
Outdated
| depends_on "sdl_ttf" | ||
| depends_on "freetype" | ||
| depends_on "libpng" | ||
| depends_on "glew" if build.with? "opengl" |
There was a problem hiding this comment.
same story here. This should be changed to
option "without-glew", "Disable OpenGL post-processing renderer"
option "with-laserdisc", "Enable Laserdisc support"
deprecated_option "without-opengl" => "without-glew"
...
depends_on "glew" => :optional
There was a problem hiding this comment.
s/:optional/:recommended/
ilovezfs
reviewed
Feb 12, 2017
Formula/openmsx.rb
Outdated
| depends_on "sdl_ttf" | ||
| depends_on "freetype" | ||
| depends_on "libpng" | ||
| depends_on "glew" => :optional |
There was a problem hiding this comment.
sorry I meant :recommended here
ilovezfs
approved these changes
Feb 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Built without optimization to work around an upstream LLVM/clang bug, which has been reported upstream.