refactor: OPTIC-914: Remove Stale Feature Flag - fflag_fix_front_lsdv…

…_4673_rect3point_relative_310523_short (#6162) Co-authored-by: Raul Martin <[email protected]>
HumanSignal · Aug 6, 2024 · 0d263aa · 0d263aa
1 parent ce7f119
commit 0d263aa
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 21 deletions.
diff --git a/label_studio/core/feature_flags/stale_feature_flags.py b/label_studio/core/feature_flags/stale_feature_flags.py
@@ -13,7 +13,6 @@
     'fflag_fix_front_lsdv_4600_lead_time_27072023_short': False,
     'fflag_feat_front_lops_e_10_updated_ux_short': False,
     'fflag_fix_front_lsdv_4988_dynamic_no_label_120523_short': True,
-    'fflag_fix_front_lsdv_4673_rect3point_relative_310523_short': True,
     'fflag_fix_back_lsdv_4648_annotator_filter_29052023_short': True,
     'fflag_feat_back_lsdv_5035_use_created_at_from_draft_for_annotation_256052023_short': True,
     'fflag_feat_front_lsdv_3025_outliner_filter_short': False,
@@ -53,7 +52,6 @@
     'fflag-feat-front-dev-2982-label-weights-settings': True,
     'ff_front_dev_2575_projects_list_performance_280622_short': True,
     'ff_front_dev_2432_auto_save_polygon_draft_210622_short': True,
-    'ff_front_dev_2132_rotating_bounding_box': True,
     'ff_front_dev_2431_delete_polygon_points_080622_short': True,
     'ff_front_dev_2394_zoomed_transforms_260522_short': True,
     'ff_front_dev_2290_draft_in_annotation_history_short': True,

diff --git a/web/libs/editor/src/tags/control/Rectangle.js b/web/libs/editor/src/tags/control/Rectangle.js
@@ -6,7 +6,6 @@ import { customTypes } from "../../core/CustomTypes";
 import { AnnotationMixin } from "../../mixins/AnnotationMixin";
 import SeparatedControlMixin from "../../mixins/SeparatedControlMixin";
 import { ToolManagerMixin } from "../../mixins/ToolManagerMixin";
-import { FF_DEV_2132, FF_DEV_3793, FF_LSDV_4673, isFF } from "../../utils/feature-flags";
 
 /**
  * The `Rectangle` tag is used to add a rectangle (Bounding Box) to an image without selecting a label. This can be useful when you have only one label to assign to a rectangle.
@@ -49,7 +48,7 @@ const Model = types
     type: "rectangle",
   })
   .volatile(() => ({
-    toolNames: isFF(FF_DEV_2132) && (!isFF(FF_DEV_3793) || isFF(FF_LSDV_4673)) ? ["Rect", "Rect3Point"] : ["Rect"],
+    toolNames: ["Rect", "Rect3Point"],
   }));
 
 const RectangleModel = types.compose(

diff --git a/web/libs/editor/src/utils/feature-flags.ts b/web/libs/editor/src/utils/feature-flags.ts
@@ -48,9 +48,6 @@ export const FF_DEV_2100 = "ff_dev_2100_clean_unnecessary_areas_140422_short";
 // Allow to use html inside <Label/> tags
 export const FF_DEV_2128 = "ff_dev_2128_html_in_labels_150422_short";
 
-// 3-point Rectangle tool to created rotated bboxes conveniently
-export const FF_DEV_2132 = "ff_front_dev_2132_rotating_bounding_box";
-
 // Show draft as the topmost item in annotation history
 export const FF_DEV_2290 = "ff_front_dev_2290_draft_in_annotation_history_short";
 
@@ -220,14 +217,6 @@ export const FF_LSDV_4620_3_ML = "fflag_fix_front_lsdv_4620_memory_leaks_100723_
  */
 export const FF_OUTLINER_OPTIM = "fflag_feat_front_lsdv_4620_outliner_optimization_310723_short";
 
-/**
- * Fixes Rect3PointTool behaviour in relative coords mode.
- * It also fixes disappearing regions in degenerate cases.
- *
- * @link https://app.launchdarkly.com/default/production/features/fflag_fix_front_lsdv_4673_rect3point_relative_310523_short
- */
-export const FF_LSDV_4673 = "fflag_fix_front_lsdv_4673_rect3point_relative_310523_short";
-
 /**
  * Fixes how presigned urls are generated and accessed to remove possibility of CORS errors.
  */

diff --git a/web/libs/editor/tests/integration/e2e/image_segmentation/tools/rect3point.cy.ts b/web/libs/editor/tests/integration/e2e/image_segmentation/tools/rect3point.cy.ts
@@ -1,12 +1,11 @@
 import { ImageView, LabelStudio } from "@humansignal/frontend-test/helpers/LSF";
 import { rect3Config, simpleImageData } from "../../../data/image_segmentation/tools/rect3point";
-import { FF_DEV_2132, FF_DEV_3793 } from "../../../../../src/utils/feature-flags";
+import { FF_DEV_3793 } from "../../../../../src/utils/feature-flags";
 
 describe("Rect3Point tool", () => {
   beforeEach(() => {
     LabelStudio.addFeatureFlagsOnPageLoad({
       [FF_DEV_3793]: true,
-      [FF_DEV_2132]: true,
     });
   });
   it("Should be able to draw region with rotation 0", () => {

diff --git a/web/libs/editor/tests/integration/feature-flags.ts b/web/libs/editor/tests/integration/feature-flags.ts
@@ -5,7 +5,6 @@ export const CURRENT_FLAGS = {
   [FLAGS.FF_PROD_309]: true,
   [FLAGS.FF_LSDV_4930]: true,
   [FLAGS.FF_LSDV_4992]: true,
-  [FLAGS.FF_LSDV_4673]: true,
   [FLAGS.FF_DEV_2100]: true,
   [FLAGS.FF_DEV_2715]: true,
   [FLAGS.FF_LSDV_4620_3]: true,

diff --git a/web/libs/frontend-test/src/feature-flags.ts b/web/libs/frontend-test/src/feature-flags.ts
@@ -51,9 +51,6 @@ export const FF_DEV_2100 = "ff_dev_2100_clean_unnecessary_areas_140422_short";
 // Allow to use html inside <Label/> tags
 export const FF_DEV_2128 = "ff_dev_2128_html_in_labels_150422_short";
 
-// 3-point Rectangle tool to created rotated bboxes conveniently
-export const FF_DEV_2132 = "ff_front_dev_2132_rotating_bounding_box";
-
 // Show draft as the topmost item in annotation history
 export const FF_DEV_2290 = "ff_front_dev_2290_draft_in_annotation_history_short";