Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-914: Remove Stale Feature Flag - fflag_fix_front_lsdv_4673_rect3point_relative_310523_short #6162

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Aug 1, 2024

Careful in this pr are 2 Feature Flag removal, the 2 of them where part of an if that it is worth it to remove all together

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Remove two stale feature flags that have been in that state since June.

fflag_fix_front_lsdv_4673_rect3point_relative_310523_short
ff_front_dev_2132_rotating_bounding_box

both with value True

What does this fix?

Clean Code

What is the new behavior?

No change

@github-actions github-actions bot added the feat label Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit dfe5b83
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66ac1677a366a70008aa271e

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit dfe5b83
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66ac1677d8360d0008b8c0c1

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (91ef076) to head (dfe5b83).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6162   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          168      168           
  Lines        13650    13650           
========================================
  Hits         10480    10480           
  Misses        3170     3170           
Flag Coverage Δ
pytests 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr changed the title feat: OPTIC-914: Remove Stale Feature Flag - fflag_fix_front_lsdv_4673_rect3point_relative_310523_short refactor: OPTIC-914: Remove Stale Feature Flag - fflag_fix_front_lsdv_4673_rect3point_relative_310523_short Aug 1, 2024
@luarmr luarmr force-pushed the fb-optic-914/remove-stale branch from 1b0ea53 to dfe5b83 Compare August 1, 2024 23:12
@luarmr luarmr requested a review from hlomzik August 1, 2024 23:41
@luarmr luarmr merged commit 0d263aa into develop Aug 6, 2024
40 checks passed
@luarmr luarmr deleted the fb-optic-914/remove-stale branch August 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants