Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support loading TimeSeries URL from sub-property of data (#5610) #5611

Closed
wants to merge 1 commit into from

Conversation

harrymander
Copy link

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What does this fix?

Fixes #5610

Copy link

netlify bot commented Mar 20, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0888ec7

Copy link

netlify bot commented Mar 20, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0888ec7

@hlomzik
Copy link
Collaborator

hlomzik commented Apr 29, 2024

/jira create bug LEAP

@hlomzik
Copy link
Collaborator

hlomzik commented Apr 29, 2024

@harrymander thank you! that's a very helpful and simple fix we really need! I'll run it through our internal process and will merge soon

jombooth added a commit that referenced this pull request May 14, 2024
…ata (#5610) (#5883)

contributed by @harrymander in #5611 

### PR fulfills these requirements
- [x] Commit message(s) and PR title follows the format
`[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made`
ex. `fix: DEV-XXXX: Removed inconsistent code usage causing intermittent
errors`
- [ ] Tests for the changes have been added/updated (for bug
fixes/features)
- [ ] Docs have been added/updated (for bug fixes/features)
- [ ] Best efforts were made to ensure docs/code are concise and
coherent (checked for spelling/grammatical errors, commented out code,
debug logs etc.)
- [x] Self-reviewed and ran all changes on a local instance (for bug
fixes/features)

#### Change has impacts in these area(s)
_(check all that apply)_
- [ ] Product design
- [ ] Backend (Database)
- [ ] Backend (API)
- [x] Frontend

#### What does this fix?
Fixes #5610

---------

Co-authored-by: robot-ci-heartex <[email protected]>
@jombooth
Copy link
Contributor

just closing because your code was merged to develop in #5883 for CI/process related reasons. We'll make sure you're credited in our next release!

@jombooth jombooth closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in fetching TimeSeries URL from sub-property in task data object
3 participants