Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1049: support loading TimeSeries URL from sub-property of data (#5610) #5883

Merged
merged 2 commits into from
May 14, 2024

Conversation

jombooth
Copy link
Contributor

contributed by @harrymander in #5611

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What does this fix?

Fixes #5610

@github-actions github-actions bot added the fix label May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit da268b3
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6643bfc7bac73a00086f39e0

Copy link

netlify bot commented May 14, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit da268b3
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6643bfc7d1fbaf0009d8de03

@jombooth
Copy link
Contributor Author

I was able to confirm the fix locally - nice work @harrymander!

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice contribution 🚀

@jombooth jombooth enabled auto-merge (squash) May 14, 2024 20:53
@jombooth jombooth merged commit 303282b into develop May 14, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in fetching TimeSeries URL from sub-property in task data object
3 participants