Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-447: Filters don't pass to label stream in DM #6410

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

this resolves a bug where selecting all tasks while having a filter applied then going through labeling stream would give us tasks that are outside the filter

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 49506fa
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66ec24a756fdd10009641a7d

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 49506fa
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66ec24a73c436d0008439691

@github-actions github-actions bot added the fix label Sep 19, 2024
@yyassi-heartex yyassi-heartex merged commit 0400243 into develop Sep 20, 2024
33 checks passed
@CarlosNacher
Copy link

Hey,

I have upgraded to version 1.14.0 (which has this PR implemented) and I still have the problem. If I apply a filter and press "Label All Tasks" button, some tasks outside the filter appear. If, instead, I select checkbox and press "Label N tasks" button, it only shows the ones that are inside the filter but not in Random Sampling mode but in Sequential one (I don't want that).

Why is this happening to me if the bug was fixed? :/

Thank you so much in advance!

@yyassi-heartex
Copy link
Contributor Author

Hey,

I have upgraded to version 1.14.0 (which has this PR implemented) and I still have the problem. If I apply a filter and press "Label All Tasks" button, some tasks outside the filter appear. If, instead, I select checkbox and press "Label N tasks" button, it only shows the ones that are inside the filter but not in Random Sampling mode but in Sequential one (I don't want that).

Why is this happening to me if the bug was fixed? :/

Thank you so much in advance!

Hey @CarlosNacher, its possible you dont have the updated compiled frontend files.
to do that you can run make frontend-build to get the updated dependencies and recompile front end.

I hope that helps!

@CarlosNacher
Copy link

CarlosNacher commented Nov 8, 2024

Hey @yyassi-heartex, thank you for your response. I don't have a labelstudio project locally cloned and don't have access to Makefile, project folders or whateve. Instead I am serving a image through a docker-compose (pulling from heartexlabs/label-studio:latest). Could you help me to achieve your solution with my setup?

Many thanks!

@yyassi-heartex
Copy link
Contributor Author

Happy to assist!
since you're running docker lets do a rebuild - which will include the frontend files getting recompiled.
we do that by running make docker-run-dev
if errors appear in the log about missing columns or needing to run migration, you can do that by running make docker-migrate-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants