Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-447: Filters don't pass to label stream in DM #6410

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: OPTIC-447: Filters don't pass to label stream in DM #6410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25e10d
fix: OPTIC-447: Filters don't pass to label stream in DM
yyassi-heartex Sep 19, 2024
49506fa
allowing selectAll regardless of exclusion
yyassi-heartex Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions web/libs/datamanager/src/stores/AppStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,14 +635,17 @@ export const AppStore = types
};

if (actionId === "next_task") {
if (labelStreamMode === "all") {
const isSelectAll = actionParams.selectedItems.all === true;
yyassi-heartex marked this conversation as resolved.
Show resolved Hide resolved
const isAllLabelStreamMode = labelStreamMode === "all";
const isFilteredLabelStreamMode = labelStreamMode === "filtered";
if (isAllLabelStreamMode && !isSelectAll) {
delete actionParams.filters;

if (actionParams.selectedItems.all === false && actionParams.selectedItems.included.length === 0) {
delete actionParams.selectedItems;
delete actionParams.ordering;
}
} else if (labelStreamMode === "filtered") {
} else if (isFilteredLabelStreamMode) {
delete actionParams.selectedItems;
}
}
Expand Down
Loading