Adding Changes for F1888 Object Expiration Filtering #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinash1IBM
suggested changes
Nov 11, 2024
ibm/service/cos/resource_ibm_cos_bucket_lifecycle_configuration_test.go
Outdated
Show resolved
Hide resolved
ibm/service/cos/resource_ibm_cos_bucket_lifecycle_configuration_test.go
Outdated
Show resolved
Hide resolved
avinash1IBM
suggested changes
Nov 18, 2024
ibm/service/cos/resource_ibm_cos_bucket_lifecycle_configuration_test.go
Outdated
Show resolved
Hide resolved
avinash1IBM
approved these changes
Nov 18, 2024
hkantare
reviewed
Dec 15, 2024
| }, | ||
| }, | ||
| }, | ||
| "and": { |
There was a problem hiding this comment.
Can user provide combination of multiple filters along with other filter (tags, prefix...so on) if not can we add some conflicts with can't provider filter.0.and with other arguments
There was a problem hiding this comment.
We cannot add other filters with each other.
But the parent element lifecycle_rule can multiple rules so we cant add the conflict like lifecycle.0.filter. to the arguments.
|
Can you fix conflicts |
hkantare
previously approved these changes
Dec 24, 2024
hkantare
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression Result :
F1888_regression_result_latest.docx