update webpack versions and config #59
Conversation
There was a problem hiding this comment.
@jamesmisson, you need to commit package-lock.json along with package.json; the missing lockfile changes are the reason that the build is breaking on this branch.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
webpack.config.js
Outdated
| node: { | ||
| net: 'empty' | ||
| }, | ||
| mode: 'development', |
There was a problem hiding this comment.
Do you think it might be better to default to production? I'm not entirely sure what the differences are, but since we use this build process to create the package for distribution, I'm thinking a production-oriented build might be more appropriate than a dev-oriented build.
There was a problem hiding this comment.
(And maybe we need a different action to do a dev build for development purposes... I'm sure there must be a best practice around this, but I'm not sure what it is -- maybe we need to look for precedents elsewhere).
There was a problem hiding this comment.
Definitely, I'm not sure why I put development here! Fixed.
This should solve the issue that #56 is having. The updated Webpack needs a new config file, and compatibility with webpack-cli.