Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack versions and config #59

Merged
merged 3 commits into from
Dec 4, 2024
Merged

update webpack versions and config #59

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0219759
update webpack versions and config
jamesmisson Dec 3, 2024
66b31c5
add package-lock.json
jamesmisson Dec 3, 2024
d129149
Switch to production mode
jamesmisson Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"typedoc": "0.14.0",
"typescript": "^5",
"typescript-tslint-plugin": "^0.5.5",
"webpack": "^4.28.3",
"webpack-cli": "^3.1.2"
"webpack": "^5.96.1",
"webpack-cli": "^5.1.4"
},
"dependencies": {
"@edsilv/http-status-codes": "^1.0.3",
Expand Down
4 changes: 1 addition & 3 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ const config = {
library: 'manifold',
umdNamedDefine: true
},
node: {
net: 'empty'
},
mode: 'development',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it might be better to default to production? I'm not entirely sure what the differences are, but since we use this build process to create the package for distribution, I'm thinking a production-oriented build might be more appropriate than a dev-oriented build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And maybe we need a different action to do a dev build for development purposes... I'm sure there must be a best practice around this, but I'm not sure what it is -- maybe we need to look for precedents elsewhere).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, I'm not sure why I put development here! Fixed.

// Add resolve for `tsx` and `ts` files, otherwise Webpack would
// only look for common JavaScript file extension (.js)
resolve: {
Expand Down