Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC-51] DAVE worlds and respective launch files #4

Merged
merged 4 commits into from
Jun 27, 2024
Merged

[GSOC-51] DAVE worlds and respective launch files #4

merged 4 commits into from
Jun 27, 2024

Conversation

hmoyen
Copy link
Collaborator

@hmoyen hmoyen commented Jun 25, 2024

This PR introduces two main features:

  1. World files:

    • New DAVE world files compatible with new Gazebo Harmonic, but still without plugins.
    • Some textures and models were replaced, and now all worlds import models from Fuel.
  2. ROS 2 Launch Files:

    • Launch files were added to dave_demos package, which call a world file in the dave_worlds package.

@woensug-choi
Copy link

@hmoyen Could we have more universal launch file using launch cobfigurationand arguments?
examples are at examples/dave_demos/launch/model_in_empty_world.launch.py

also please append some readme yo examples/dave_demos/README about launching worlds.

@hmoyen
Copy link
Collaborator Author

hmoyen commented Jun 25, 2024

@woensug-choi Sure! Will work on that

@hmoyen
Copy link
Collaborator Author

hmoyen commented Jun 26, 2024

@woensug-choi Just added to the dave_demos README how to launch a world using a world_name argument

@woensug-choi woensug-choi changed the title DAVE worlds and respective launch files [GSOC-51] DAVE worlds and respective launch files Jun 26, 2024
@woensug-choi
Copy link

woensug-choi commented Jun 27, 2024

Thank you for putting it all together. I've made modifications on it! Please check :)
Also, could you make a ticket on Notion for issues at the bottom? We may not deal with it now but someday.

README

  • changed to launch ocean_waves as the first command to try since integrated world takes too long to launch at start (taking long time to download model files)

    • ros2 launch dave_demos dave_world.launch.py world_name:=dave_ocean_waves
  • Add description about downloading the files from https://app.gazebosim.org/

  • Old sea surface removed (using brand new gazebo generic one)

Worlds

  • Common Mods
  • dave_ocean_waves
    • removed ode tag since it was causing warning that is unnecessary
  • dave_ocean_waves_transient_current
    • Kept. Need to add plugins later
  • dave_ocean_waves_occluded_bottom
    • Changed name to dave_ocean_waves_mossy_ground
  • dave_ocean_waves_dvl_current_profiling
    • Removed. Let's use dave_ocean_waves_transient_current and add dvl at the launch file with uploading the model there
  • dave_ocean_models
    • Manually defined GUI so that we can set initial position of the camera (I couldn't figure out just defining camera pose without all other GUI settings)
  • dave_new_bathy_example
  • dave_mud_occlusion_demo
    • Just removing it. seems to complex problem to GSoC
  • dave_graded_seabed
    • Removed BOP Panel
    • Rotated Heightmap and Changed light that equal to dave_ocean_waves
  • dave_electrical_mating
    • Adjusted positions and camera view angle
  • dave_bimanual_example
    • Reposition, add heightmap
  • dave_plug_and_socket_demo
    • renamed to dave_plug_and_socket
    • Reposition, add heightmap
  • valve_manipulation
    • Removing it for now. (didn't see any useful models being loaded)
  • dave_Santorini
    • Rename to dave_santorini(small letters only)
    • Reposition and camera view angle set
  • dave_integrated
    • reposition and camera view angle set

Issues

@hmoyen hmoyen merged commit 585101d into ros2 Jun 27, 2024
@hmoyen hmoyen deleted the worlds branch July 17, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants