Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author/User Identifiers: Suggested Additions #1375

Closed
eaquigley opened this issue Jan 22, 2015 · 9 comments · Fixed by #6358
Closed

Author/User Identifiers: Suggested Additions #1375

eaquigley opened this issue Jan 22, 2015 · 9 comments · Fixed by #6358
Assignees
Labels
Feature: Account & User Info Feature: Metadata User Role: Curator Curates and reviews datasets, manages permissions

Comments

@eaquigley
Copy link
Contributor

In addition to ORCID and ISNI, there has been user feedback on including Digital Author Identification. I'd imagine there might be some other ones as well. This ticket is to review which identifiers to add.

@eaquigley eaquigley added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Design labels Jan 22, 2015
@eaquigley eaquigley added this to the Post 4.0 milestone Jan 22, 2015
@posixeleni
Copy link
Contributor

@eaquigley whats the best documentation to look at for DAI? http://en.wikipedia.org/wiki/Digital_Author_Identification

@eaquigley
Copy link
Contributor Author

@posixeleni I found this: https://wiki.surfnet.nl/display/standards/DAI but this would definitely be worth reaching out to the DANS partners to get more information for us to be able to implement it after 4.0 is done.

@scolapasta scolapasta modified the milestones: In Review - Long Term, In Review - Short Term May 8, 2015
@mheppler mheppler added Feature: Metadata Feature: Account & User Info and removed UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Jan 27, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Jun 25, 2017

See also: authorIdentifierScheme : Add "ResearcherID" as one of the option #3169

@pdurbin pdurbin removed the Triaged label Jun 25, 2017
@pdurbin pdurbin added the User Role: Curator Curates and reviews datasets, manages permissions label Jul 4, 2017
@PaulBoon
Copy link
Contributor

PaulBoon commented Nov 7, 2019

We at DANS are planning to add the DAI, but we could also add ResearcherID and ScopusID if that is a useful addition.

@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2019

@PaulBoon sounds good. Do you want me to assign this issue and #3169 to you and put them in the "Community Dev" column at https://github.com/orgs/IQSS/projects/2 ?

@mderuijter
Copy link
Contributor

mderuijter commented Nov 11, 2019

@pdurbin Could you please assign this issue to me?

And regarding this issue, I found some validation coder here:

final public static String REGEX_ORCID = "^\\d{4}-\\d{4}-\\d{4}-(\\d{4}|\\d{3}X)$";

I tried testing these validations for the various identifierScheme's but the validation doesn't seem to be active.

Does this need to be turned on via a configuration option?

@pdurbin
Copy link
Member

pdurbin commented Nov 12, 2019

I tried testing these validations for the various identifierScheme's but the validation doesn't seem to be active.

@mderuijter good question. It looks like the only place that the ORCID regex is excercised in the live code is during the export of Schema.org JSON-LD here:

https://github.com/IQSS/dataverse/blob/v4.17/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java#L1646

Basically, if you don't provide a valid ORCID ID, it won't be added to the Schema.org JSON-LD output.

It would be nice to use this validation much earlier, of course, such as when the user is entering their ORCID ID while creating their dataset. #5271 is related as is the comment at #4371 (comment)

@mderuijter
Copy link
Contributor

@pdurbin alright, thanks for clearing that up!

My colleagues here at DANS would also be interested in using this validation earlier on.

@pdurbin
Copy link
Member

pdurbin commented Nov 12, 2019

@mderuijter great! You are welcome to work on #5271 or you could create a new issue in your own words to describe the feature or bug fix you want. Sometimes we try to express issues as user stories... "As someone creating a dataset, I want assurance that my ORCID ID is in the right format." Something like that. 😄

kcondon added a commit that referenced this issue Nov 12, 2019
pdurbin added a commit that referenced this issue Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Account & User Info Feature: Metadata User Role: Curator Curates and reviews datasets, manages permissions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants