Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataverse Alias shows in the URL #235

Closed
eaquigley opened this issue Jul 9, 2014 · 14 comments
Closed

Dataverse Alias shows in the URL #235

eaquigley opened this issue Jul 9, 2014 · 14 comments
Assignees
Labels
Type: Feature a feature request

Comments

@eaquigley
Copy link
Contributor


Author Name: Elizabeth Quigley (@eaquigley)
Original Redmine Issue: 3649, https://redmine.hmdc.harvard.edu/issues/3649
Original Date: 2014-03-06
Original Assignee: Gustavo Durand


Currently, the alias a user enters in for a dataverse doesn't appear in the URL so this ticket is a reminder that it needs to happen.

https://trello.com/c/ZUbdgjRc/20-urls has a link to Pretty URLs for JavaServer Faces and Java Application Servers | OCPsoft - http://ocpsoft.org/prettyfaces/

@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 5, Dataverse 4.0: In Review Jul 15, 2014
@scolapasta scolapasta modified the milestones: Beta 5 - Dataverse 4.0, Beta 7 - Dataverse 4.0 Aug 20, 2014
@eaquigley
Copy link
Contributor Author

Related to #331 and #621

@pdurbin
Copy link
Member

pdurbin commented Oct 22, 2014

Once this feature has been implemented, when I send a link to my dataverse, what will the link look like? What if my dataverse is deep within a tree? Would it look like the third option below?

I guess I'm wondering how pretty we can make our URLs. I'm also wondering if we're going to have our URLs reflect the dataverse's position in the tree. Back at #123 (comment) I was wondering if we could/should support use of the same alias as long as it's in a different namespace (e.g. cars vs. cats), like this:

@scolapasta
Copy link
Contributor

I think we should not support that - I think it makes the URLs longer than
they may need to be AND when we implement moving, it would break URLs.

On Wed, Oct 22, 2014 at 2:32 PM, Philip Durbin [email protected]
wrote:

Once this feature has been implemented, when I send a link to my
dataverse, what will the link look like? What if my dataverse is deep
within a tree? Would it look like the third option below?

I guess I'm wondering how pretty we can make our URLs. I'm also wondering
if we're going to have our URLs reflect the dataverse's position in the
tree. Back at #123 (comment)
#123 (comment) I
was wondering if we could/should support use of the same alias as long as
it's in a different namespace (e.g. cars vs. cats), like this:


Reply to this email directly or view it on GitHub
#235 (comment).

@mercecrosas
Copy link
Member

Agreed. we should keep the urls short for dataverse, without using the
tree. This is also closer to what people expect now in current production.

On Wed, Oct 22, 2014 at 2:35 PM, scolapasta [email protected]
wrote:

I think we should not support that - I think it makes the URLs longer than
they may need to be AND when we implement moving, it would break URLs.

On Wed, Oct 22, 2014 at 2:32 PM, Philip Durbin [email protected]
wrote:

Once this feature has been implemented, when I send a link to my
dataverse, what will the link look like? What if my dataverse is deep
within a tree? Would it look like the third option below?

I guess I'm wondering how pretty we can make our URLs. I'm also
wondering
if we're going to have our URLs reflect the dataverse's position in the
tree. Back at #123 (comment)
#123 (comment) I
was wondering if we could/should support use of the same alias as long
as
it's in a different namespace (e.g. cars vs. cats), like this:

Reply to this email directly or view it on GitHub
#235 (comment).

Reply to this email directly or view it on GitHub
#235 (comment).

@rtreacy
Copy link
Contributor

rtreacy commented Oct 24, 2014

Pretty Faces/Rewrite has been integrated into the project. Now it is just a matter of configuring individual pages in pretty-config.xml

@pdurbin
Copy link
Member

pdurbin commented Oct 28, 2014

Agreed. we should keep the urls short for dataverse, without using the tree.

This means that there can only be one dataverse alias/URL for common words like "health" or "Canada". It's a bit of a name grab, like getting the Twitter username you want.

@mercecrosas
Copy link
Member

I wonder if we could make it a choice - datavere admins can choose either
using the tree or not in the alias. I imagine though that nobody will want
the root, that is, do we want to support:

dataverse.harvard.edu/harvard/hms/mylab

or

datavere.harvard.edu/hms/mylab

?

Should we ask the community for their opinion?

Merce

Mercè Crosas, Ph.D.
Director of Data Science, IQSS
Harvard University
http://iq.harvard.edu/merce-crosas

On Tue, Oct 28, 2014 at 9:01 AM, Philip Durbin [email protected]
wrote:

Agreed. we should keep the urls short for dataverse, without using the
tree.

This means that there can only be one dataverse alias/URL for common words
like "health" or "Canada". It's a bit of a name grab, like getting the
Twitter username you want.

Reply to this email directly or view it on GitHub
#235 (comment).

@rtreacy rtreacy removed their assignment Nov 4, 2014
@esotiri esotiri assigned esotiri and scolapasta and unassigned esotiri Nov 4, 2014
@esotiri
Copy link
Contributor

esotiri commented Nov 4, 2014

Dataverse alias showing in URL however there is still work being done in relation to this.

Also @mcrosas question is not answered so I am keeping this ticket open and passing it to @scolapasta

@mercecrosas
Copy link
Member

for sake of simplification and to make a decision soon, given our tight 4.0
schedule, let's not allow this or make it a choice. That is, we support
only:

dataverse.harvard.edu/mydataverse

In the future we could add additional options, once we hear of use cases
when this is needed. The breadcrumbs will already display the tree
structure.

Is this fine with everybody?

On Tue, Nov 4, 2014 at 4:22 PM, esotiri [email protected] wrote:

Dataverse alias showing in URL however there is still work being done in
relation to this.

Also @mcrosas https://github.com/mcrosas question is not answered so I
am keeping this ticket open and passing it to @scolapasta
https://github.com/scolapasta

Reply to this email directly or view it on GitHub
#235 (comment).

@eaquigley
Copy link
Contributor Author

Fine with me. Moving to Beta 9.

@scolapasta
Copy link
Contributor

I'm fine with that. (I do wonder what happens if we allowed / as a valid character...)

I think for 4.0, everything is resolved. QA, pelase confirm.

@scolapasta scolapasta removed their assignment Nov 5, 2014
@pdurbin
Copy link
Member

pdurbin commented Nov 5, 2014

I do wonder what happens if we allowed / as a valid character...

It would be good to test a dataverse alias with "/" in it since with SWORD since we split on "/".

@kcondon kcondon self-assigned this Nov 13, 2014
@kcondon
Copy link
Contributor

kcondon commented Nov 13, 2014

OK, this seems to be mostly done. The URL now appears as:
https://dvn-build.hmdc.harvard.edu/view-datataverse/subd2

"view-dataverse" replaces the tree and sub2 is the alias, regardless of where it is in the tree. The view-dataverse link was not specified so I am asking whether this is ok. I'm assuming so.

Alias is not appearing in the featured dataverse links.

@pdurbin
Copy link
Member

pdurbin commented Nov 26, 2018

Related: #2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature a feature request
Projects
None yet
Development

No branches or pull requests

7 participants