Installers broken, because of the new pom file structure.

[j-n-c]

What steps does it take to reproduce the issue?

• When does this issue occur?
  When trying to deploy dataverse using vagrant

• Which page(s) does it occurs on?
  N/A

• What happens?
  Running vagrant up starts the deployment process, but after configuring Solr the process fails because the python installer is unable to find a .war file:

==> default: Running provisioner: shell...
    default: Running: /tmp/vagrant-shell20220316-16786-1agei0k.sh
    default: enabling non-interactive mode
    default: 
    default: This appears to be a RedHat system; good.
    default: Checking for required components...
    default: Sorry, I can't seem to find an appropriate warfile.
    default: Are you running the installer from the right directory?

• To whom does it occur (all users, curators, superusers)?

• What did you expect to happen?
  Deployment using vagrant up should be successful

Which version of Dataverse are you using?
5.9

Any related open or closed issues to this bug report?
Not that I could find

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

• https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests

[j-n-c]

What seems to happening is that the the python installer is not able retrieve the dataverse version from the project POM. Instead it retrieves the placeholder ${revision}, which will make the installer search for file ../../target/dataverse-${revision}.war, which does not exist.

I have successfully been able to deploy dataverse using vagrant, but using the revision field from the POM in modules/dataverse-parent. Does this fileld contain the dataverse release version?

If it does, the installer can be fixed using the lines below and I'd be more than happy to submit a PR:

tree = ET.ElementTree(file='../../modules/dataverse-parent/pom.xml')
for elem in tree.iter("*"):
    if elem.tag == '{http://maven.apache.org/POM/4.0.0}revision':
        warfileVersion = elem.text

[pdurbin]

docker-aio is also affected. I'm getting this error on develop:

/opt/dv/testdata/scripts/installer
Payara setup complete
Wed Mar 16 15:05:40 UTC 2022
remote failure: File not found : /opt/dv/dvinstall/dataverse.war
Command deploy failed.

I'll update the title of this issue to reflect this.

[landreev]

Thank you for catching this!
I feel bad for missing this, because I had spent some time looking at the PR that changed the pom files; I just somehow got it reversed, where the parent, and the project pom files were ending up, when thinking about it in the context of the installer.