Installer fixes, reflecting the new pom file structure #8494 #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy to add the perl installer fix to this PR. |
|
Of course the makefile that builds the installer bundle is also broken, for the same very reason. I can add a fix for that too. |
landreev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix python installer search for dataverse .war file. Currently deploying dataverse with vagrant is not working.
[from @landreev:] The PR now includes the fixes for the old school (perl) installer, and the installer Makefile as well.
Which issue(s) this PR closes:
Closes #8494
Special notes for your reviewer:
Check if the revision field in modules/dataverse-parent/pom.xml is a suitable location for retrieving dataverse version
Suggestions on how to test this:
[from @landreev:] It should now be possible to make the installer bundle; and run the installer successfully from the source tree.
In other words, the QA for this PR is one of the standard steps of making a release. This means this issue would be found eventually - but this PR removes the element of surprise from the process.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: