Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Autoscaled EC2 instances currently need to be accessible through the internet #195

Closed
8 tasks done
Tracked by #670
mrnicegyu11 opened this issue Jun 26, 2023 · 2 comments
Closed
8 tasks done
Tracked by #670
Assignees
Labels
blocked / paused p:mid-prio SECURITY t:infra-ops Adjustments to the way or resources with that microservices are run

Comments

@mrnicegyu11
Copy link
Member

mrnicegyu11 commented Jun 26, 2023

Moved from gitlab, original message from @sanderegg:

In the current implementation, it is not possible to start an EC2 instance for autoscaling without making it available through the internet.
This is security wise a problem, as anyone with the IP and ssh may be able to connect on the machine.
Currently it is necessary for the machine to be Internet accessible due to the following facts:
- need to ssh on the machine for debugging purposes
- the machine needs to access Dockerhub to pull images

Please devise what should be done there. [@kaiser](https://github.com/kaiser) talked about having some kind of router.
Take your time to find out, but I do think it would be desirable before we unleash sim4life full

Tasks

Preview Give feedback
  1. a:autoscaling a:clusters-keeper
    sanderegg
  2. FAST
    sanderegg
  3. a:clusters-keeper
    sanderegg
  4. FAST
    sanderegg
  5. a:infra+ops
    sanderegg
@mrnicegyu11 mrnicegyu11 added p:mid-prio t:infra-ops Adjustments to the way or resources with that microservices are run SECURITY labels Jun 26, 2023
@mrnicegyu11
Copy link
Member Author

Possible mitigations:

  • For SSHing a jump-host or bastion-host pattern could be used.
  • Egress internet access to e.g. dockerhub can be given via a aws internet gateway

@YuryHrytsuk YuryHrytsuk self-assigned this May 14, 2024
@YuryHrytsuk YuryHrytsuk added this to the Leeroy Jenkins milestone May 14, 2024
@YuryHrytsuk YuryHrytsuk changed the title Autoscaling: AWS EC2 instances currently need to be accessible through the internet Security: Autoscaled EC2 instances currently need to be accessible through the internet May 14, 2024
@sanderegg sanderegg self-assigned this May 28, 2024
@YuryHrytsuk
Copy link
Collaborator

Waiting for PROD release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked / paused p:mid-prio SECURITY t:infra-ops Adjustments to the way or resources with that microservices are run
Projects
None yet
Development

No branches or pull requests

3 participants