🎨Autoscaling/Clusters-keeper: disable public IP address #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:autoscaling
sanderegg
requested review from
YuryHrytsuk,
GitHK,
pcrespov,
matusdrobuliak66 and
mrnicegyu11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5882 +/- ##
=========================================
- Coverage 84.5% 83.4% -1.1%
=========================================
Files 10 980 +970
Lines 214 43856 +43642
Branches 25 234 +209
=========================================
+ Hits 181 36615 +36434
- Misses 23 7192 +7169
- Partials 10 49 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
YuryHrytsuk
approved these changes
May 28, 2024
mrnicegyu11
approved these changes
May 28, 2024
sanderegg
force-pushed
the
ec2s-disable-public-ip
branch
from
392234a to
bbb4712
Compare
|
matusdrobuliak66
approved these changes
May 28, 2024
17 tasks
matusdrobuliak66
added a commit
to matusdrobuliak66/osparc-simcore
that referenced
this pull request
Jul 18, 2024
…Foundation#5882)" This reverts commit 752d353.
matusdrobuliak66
added a commit
to matusdrobuliak66/osparc-simcore
that referenced
this pull request
Jul 18, 2024
…Foundation#5882)" This reverts commit 752d353.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops checklist