Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨Clusters maintenance script: refactoring and add SSH tunneling #5886

Merged
merged 19 commits into from
Jun 4, 2024
Merged

🔨Clusters maintenance script: refactoring and add SSH tunneling #5886

merged 19 commits into from
Jun 4, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 28, 2024 •
edited
Loading

What do these changes do?

  • Adds SSH tunneling via sshtunnel library
  • refactor script to become a package
  • refactor script into multiple modules
    -> it is again compatible with AWS-master/staging AND sim4life.io.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label May 28, 2024
@sanderegg sanderegg added this to the Leeroy Jenkins milestone May 28, 2024
@sanderegg sanderegg self-assigned this May 28, 2024
@sanderegg sanderegg force-pushed the upgrade-maintenance-script branch from fcbf984 to 51f10b1 Compare June 3, 2024 16:43
@sanderegg sanderegg changed the title 🎨Clusters maintenance script: add SSH tunneling 🎨♻️Clusters maintenance script: add SSH tunneling Jun 3, 2024
@sanderegg sanderegg changed the title 🎨♻️Clusters maintenance script: add SSH tunneling 🎨♻️Clusters maintenance script: refactoring and add SSH tunneling Jun 3, 2024
@sanderegg sanderegg marked this pull request as ready for review June 3, 2024 16:47
@sanderegg sanderegg requested a review from pcrespov as a code owner June 3, 2024 16:47
@sanderegg sanderegg mentioned this pull request Jun 3, 2024
Closed
mrnicegyu11
mrnicegyu11 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look, this is getting very sophisticated. Thanks for handling the security enhancement form YH on your side as well! Nice

scripts/maintenance/computational-clusters/autoscaled_monitor/ssh.py Show resolved Hide resolved
YuryHrytsuk
YuryHrytsuk approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

scripts/maintenance/computational-clusters/autoscaled_monitor/cli.py Show resolved Hide resolved
scripts/maintenance/computational-clusters/autoscaled_monitor/ec2.py Show resolved Hide resolved
pcrespov
pcrespov approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.

MINOR: this is not part of the functionality, therefore I would rather mark it as 🔨 Add or update development scripts

@sanderegg sanderegg changed the title 🎨♻️Clusters maintenance script: refactoring and add SSH tunneling 🔨Clusters maintenance script: refactoring and add SSH tunneling Jun 4, 2024
@sanderegg sanderegg force-pushed the upgrade-maintenance-script branch from 9160833 to e29fbe6 Compare June 4, 2024 09:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sanderegg sanderegg merged commit 3f7d067 into ITISFoundation:master Jun 4, 2024
52 checks passed
@sanderegg sanderegg deleted the upgrade-maintenance-script branch June 4, 2024 10:19
This was referenced Jun 10, 2024
Closed
Closed
matusdrobuliak66 added a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Jul 18, 2024
@matusdrobuliak66
revert ITISFoundation#5886
e10fcc7
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 18, 2024
Merged
1 task
sanderegg added a commit to sanderegg/osparc-simcore that referenced this pull request Jul 23, 2024
@sanderegg
🔨Clusters maintenance script: refactoring and add SSH tunneling (ITIS…
99de7c6 
…Foundation#5886)
sanderegg added a commit to sanderegg/osparc-simcore that referenced this pull request Jul 23, 2024
@sanderegg
🔨Clusters maintenance script: refactoring and add SSH tunneling (ITIS…
72e6205 
…Foundation#5886)
sanderegg added a commit to sanderegg/osparc-simcore that referenced this pull request Jul 23, 2024
@sanderegg
🔨Clusters maintenance script: refactoring and add SSH tunneling (ITIS…
cebe95c 
…Foundation#5886)
sanderegg added a commit that referenced this pull request Jul 23, 2024
@sanderegg
🔨Clusters maintenance script: refactoring and add SSH tunneling (#5886)…
24cfdbb 
… - revert the reverted (#6091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Milestone
Leeroy Jenkins
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderegg @mrnicegyu11 @pcrespov @YuryHrytsuk