Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove R_CLONE_ENABLED and make clusters-keeper 0 replicas #370

Merged

Conversation

YuryHrytsuk
Copy link
Collaborator

@GitHK, please, confirm that removing R_CLONE_ENABLED is safe

@mguidon do we disable somehow clusters-keeper on aws prod? Currently, we have clusters-keeper replicas: 1 for aws staging and production. May it lead to any unexpected behaviour on aws prod?

@YuryHrytsuk
Copy link
Collaborator Author

As of discussion with @mguidon, it shall be fine to have replicas: 1 on aws prod. However, for safety I will manually set replicas to 0 after deploy.

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX

@YuryHrytsuk
Copy link
Collaborator Author

R_CLONE related PR: ITISFoundation/osparc-simcore#4502

@YuryHrytsuk
Copy link
Collaborator Author

clusters-keeper PR: ITISFoundation/osparc-simcore#4591

@YuryHrytsuk YuryHrytsuk merged commit 8c0c862 into ITISFoundation:main Sep 25, 2023
@GitHK
Copy link
Contributor

GitHK commented Sep 26, 2023

totally safe. R_CLONE_ENABLED is no longer part of the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants