-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Meet the clusters-keeper service (⚠️ devops) #4591
✨Meet the clusters-keeper service (⚠️ devops) #4591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4591 +/- ##
=========================================
+ Coverage 75.0% 85.3% +10.3%
=========================================
Files 897 1040 +143
Lines 38615 44269 +5654
Branches 668 1013 +345
=========================================
+ Hits 28984 37792 +8808
+ Misses 9481 6259 -3222
- Partials 150 218 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
|
297071b
to
46ac6a0
Compare
46ac6a0
to
36f3e3e
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Code Climate has analyzed commit 36f3e3e and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Clusters-Keepers....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clusters-keeper: Because every cluster deserves a guardian! 🛡️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is not connected to anything.
Maybe some tips for the future
What do these changes do?
Brings a new service to maintain external clusters, note that this service currently does nothing, this the skeleton and the initial unit tests.
Related issue/s
How to test
DevOps Checklist