Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Meet the clusters-keeper service (⚠️ devops) #4591

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 8, 2023

What do these changes do?

Brings a new service to maintain external clusters, note that this service currently does nothing, this the skeleton and the initial unit tests.

  • 99% code coverage
  • integrated in CI
  • pre-populated with ec2 client (currently a duplicate from autoscaling), rabbitmq client and redis client
  • ⚠️ devops: this is a new service, it will need its entries in ops-environment

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added this to the Sundae milestone Aug 8, 2023
@sanderegg sanderegg self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4591 (36f3e3e) into master (330fa2f) will increase coverage by 10.3%.
The diff coverage is 98.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4591      +/-   ##
=========================================
+ Coverage    75.0%   85.3%   +10.3%     
=========================================
  Files         897    1040     +143     
  Lines       38615   44269    +5654     
  Branches      668    1013     +345     
=========================================
+ Hits        28984   37792    +8808     
+ Misses       9481    6259    -3222     
- Partials      150     218      +68     
Flag Coverage Δ
integrationtests 61.6% <ø> (-0.6%) ⬇️
unittests 84.3% <98.4%> (+7.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...eeper/src/simcore_service_clusters_keeper/_meta.py 86.9% <86.9%> (ø)
...src/simcore_service_clusters_keeper/modules/ec2.py 97.3% <97.3%> (ø)
...er/src/simcore_service_clusters_keeper/__init__.py 100.0% <100.0%> (ø)
...ce_clusters_keeper/api/dependencies/application.py 100.0% <100.0%> (ø)
.../src/simcore_service_clusters_keeper/api/health.py 100.0% <100.0%> (ø)
.../src/simcore_service_clusters_keeper/api/routes.py 100.0% <100.0%> (ø)
...-keeper/src/simcore_service_clusters_keeper/cli.py 100.0% <100.0%> (ø)
...imcore_service_clusters_keeper/core/application.py 100.0% <100.0%> (ø)
...src/simcore_service_clusters_keeper/core/errors.py 100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py 100.0% <100.0%> (ø)
... and 5 more

... and 335 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/clusters-keeper branch 2 times, most recently from 297071b to 46ac6a0 Compare August 9, 2023 08:13
@sanderegg sanderegg force-pushed the comp-backend/clusters-keeper branch from 46ac6a0 to 36f3e3e Compare August 9, 2023 09:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.6% 21.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit 36f3e3e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Clusters-Keepers....

@sanderegg sanderegg changed the title ✨Meet the clusters-keeper service ✨Meet the clusters-keeper service (⚠️ devops) Aug 9, 2023
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clusters-keeper: Because every cluster deserves a guardian! 🛡️

@sanderegg sanderegg merged commit 74636e0 into ITISFoundation:master Aug 9, 2023
@sanderegg sanderegg deleted the comp-backend/clusters-keeper branch August 9, 2023 12:16
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is not connected to anything.
Maybe some tips for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants