✨ Add: Manage grafana content/assets via terraform #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnicegyu11
commented
Dec 16, 2024
mrnicegyu11
commented
Dec 16, 2024
mrnicegyu11
changed the title
YuryHrytsuk
reviewed
Dec 18, 2024
mrnicegyu11
commented
Dec 23, 2024
YuryHrytsuk
approved these changes
Jan 9, 2025
YuryHrytsuk
reviewed
Jan 9, 2025
services/monitoring/grafana/Makefile
Outdated
| @@ -0,0 +1,65 @@ | |||
| .DEFAULT_GOAL := help | |||
| REPO_BASE_DIR := $(shell git rev-parse --show-toplevel) | |||
There was a problem hiding this comment.
FYI:
This will not work if git is not there which happens if we pass ops environments as an CI Artifact (aka without .git folder in root folder)
There was a problem hiding this comment.
Thanks for letting me know, then I will have to make a special case here as well.
I am starting to wonder if this CI Artifacts approach is sustainable, I had to do a lot of customization for it and I am at this point not sure about the benefits. Is it more than just another hoop to jump through?
There was a problem hiding this comment.
--> After talking:
- It works afterall, since this is executed in a gitlab runner that clones the ops-environments repo.
- I need to refactor the cloning of ops-environments though, since it already happens 3 times.
- Do we need a github rate-limit token?
…dation#952) * fixes * update comment
* Update traefik router hardcoded priorities * remove hardcoded priority from adminpanels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based-on previous PRS:
What do these changes do?
CI_ENV_FILEtocommon.Makefile(necessary for handling S3 tf-state in grafana-tf)grafana-exportMakefile target, old python grafana import/export scriptsRelated issue/s
#778
Related PR/s
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1170
Checklist