Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is1585/cleanup storage #1586

Merged
merged 20 commits into from
Jul 16, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add code-analysis in makefiles
pcrespov committed Jul 16, 2020

Verified

This commit was signed with the committer’s verified signature.
frostming Frost Ming
commit 37ac1545cf818d75b850127883ae1310df42190c
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -151,3 +151,7 @@ prof/

# outputs from make
.stack-*.yml


# Copies
services/**/.codeclimate.yml
12 changes: 12 additions & 0 deletions scripts/common.Makefile
Original file line number Diff line number Diff line change
@@ -109,6 +109,18 @@ autoformat: ## runs black python formatter on this service's code. Use AFTER mak
mypy: $(REPO_BASE_DIR)/scripts/mypy.bash $(REPO_BASE_DIR)/mypy.ini ## runs mypy python static type checker on this services's code. Use AFTER make install-*
@$(REPO_BASE_DIR)/scripts/mypy.bash src

.PHONY: code-analysis
code-analysis: $(REPO_BASE_DIR)/.codeclimate.yml ## runs code-climate analysis
# Copying config
cp $(REPO_BASE_DIR)/.codeclimate.yml $(CURDIR)/.codeclimate.yml
# Validates $< at ${PWD}
$(REPO_BASE_DIR)/scripts/code-climate.bash validate-config
# Running analysis
$(REPO_BASE_DIR)/scripts/code-climate.bash analyze
# Removing tmp config
@-rm $(CURDIR)/.codeclimate.yml


.PHONY: version-patch version-minor version-major
version-patch: ## commits version with bug fixes not affecting the cookiecuter config
$(_bumpversion)