Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is1585/cleanup storage #1586

Merged
merged 20 commits into from
Jul 16, 2020
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 25, 2020

What do these changes do?

  • upgrade docker to slim
  • upgrade requirements
  • makefile
  • upgrade client-sdk - It requires generated an openapi.yml with proper schemas otherwise models of new version will be different from previous
    - added services/storage/client-sdk/Makefile though
  • activate tests against bf! -> Tested in-place. Added timeouts but still approved by @mguidon

Extra

  • improves autoformat and adds code-analysis recipes in common.Makefile

Related issue number

Implements #1585

How to test

make devenv
cd services/storage
make install-dev
make tests

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1586 into master will decrease coverage by 1.7%.
The diff coverage is 39.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1586     +/-   ##
========================================
- Coverage    75.4%   73.7%   -1.8%     
========================================
  Files         241     278     +37     
  Lines        9868   10889   +1021     
  Branches     1066    1177    +111     
========================================
+ Hits         7445    8028    +583     
- Misses       2110    2520    +410     
- Partials      313     341     +28     
Flag Coverage Δ
#integrationtests 56.7% <ø> (ø)
#unittests 67.4% <39.7%> (-1.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...storage/src/simcore_service_storage/__version__.py 100.0% <ø> (ø)
...ices/storage/src/simcore_service_storage/models.py 61.5% <ø> (ø)
...rvices/storage/src/simcore_service_storage/rest.py 100.0% <ø> (ø)
...storage/src/simcore_service_storage/rest_config.py 100.0% <ø> (ø)
...ces/storage/src/simcore_service_storage/datcore.py 15.4% <17.6%> (-0.1%) ⬇️
...age/src/simcore_service_storage/datcore_wrapper.py 56.1% <42.8%> (-0.4%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 65.8% <68.4%> (-0.1%) ⬇️
services/storage/src/simcore_service_storage/db.py 75.0% <100.0%> (ø)
services/storage/src/simcore_service_storage/s3.py 89.1% <100.0%> (ø)
packages/service-library/src/servicelib/utils.py 67.5% <0.0%> (ø)
... and 37 more

@pcrespov pcrespov requested review from sanderegg, mguidon and GitHK June 25, 2020 21:01
@pcrespov pcrespov marked this pull request as ready for review June 25, 2020 21:01
@pcrespov pcrespov self-assigned this Jun 25, 2020
@pcrespov pcrespov added the a:storage issue related to storage service label Jun 25, 2020
@pcrespov pcrespov added this to the Huo Guo milestone Jun 25, 2020
@pcrespov pcrespov linked an issue Jun 25, 2020 that may be closed by this pull request
4 tasks
@pcrespov pcrespov changed the title WIP: Is1585/cleanup storage Is1585/cleanup storage Jun 25, 2020
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 25, 2020
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think blackfynn should remove the dependency on boto3 as it is limiting others, due to the fact they have created an sdk.

@pcrespov pcrespov force-pushed the is1585/cleanup-storage branch 2 times, most recently from 2cd1d59 to 15fe904 Compare June 30, 2020 08:41
@pcrespov pcrespov force-pushed the is1585/cleanup-storage branch from 15fe904 to d755ba3 Compare July 9, 2020 09:32
@pcrespov pcrespov force-pushed the is1585/cleanup-storage branch from d755ba3 to 509d3e4 Compare July 16, 2020 18:03
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaG is happy. Go ahead

@pcrespov pcrespov merged commit 45add3b into ITISFoundation:master Jul 16, 2020
@pcrespov pcrespov deleted the is1585/cleanup-storage branch July 16, 2020 20:34
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
jsaq007 added a commit to jsaq007/osparc-simcore that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade and cleanup storage service
4 participants