Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform stability: #1645

Merged
merged 4 commits into from
Jul 20, 2020

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 20, 2020

What do these changes do?

  • Increased number of postgres connections
  • e2e: openNode returns nodeId
  • e2e: wait a bit longer for fetching node files

Checklist

  • Did you change any service's API? Then make sure to bundle document and upgrade version (make openapi-specs, git commit ... and then make version-*)
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

Sorry, something went wrong.

@odeimaiz odeimaiz changed the title Feature/platform stability 1 Platform stability: Jul 20, 2020
@odeimaiz odeimaiz requested a review from pcrespov July 20, 2020 12:42
@odeimaiz odeimaiz added this to the Xie-Xie milestone Jul 20, 2020
@odeimaiz odeimaiz requested review from GitHK and mguidon July 20, 2020 12:42
@odeimaiz odeimaiz marked this pull request as ready for review July 20, 2020 12:43
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #1645 into master will decrease coverage by 14.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1645      +/-   ##
=========================================
- Coverage    73.7%   58.9%   -14.9%     
=========================================
  Files         278     189      -89     
  Lines       10890    8967    -1923     
  Branches     1177    1029     -148     
=========================================
- Hits         8030    5283    -2747     
- Misses       2520    3410     +890     
+ Partials      340     274      -66     
Flag Coverage Δ
#integrationtests 56.7% <ø> (ø)
#unittests 64.8% <ø> (-2.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore-sdk/src/simcore_sdk/node_data/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...core-sdk/src/simcore_sdk/node_data/data_manager.py 0.0% <0.0%> (-95.3%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-91.2%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 20.0% <0.0%> (-80.0%) ⬇️
...ar/src/simcore_service_sidecar/celery_log_setup.py 0.0% <0.0%> (-69.3%) ⬇️
.../server/src/simcore_service_webserver/users_api.py 26.3% <0.0%> (-68.5%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 22.3% <0.0%> (-65.2%) ⬇️
...mcore_service_webserver/projects/projects_utils.py 14.1% <0.0%> (-64.8%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 24.0% <0.0%> (-64.0%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 26.0% <0.0%> (-63.8%) ⬇️
... and 159 more

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets cross fingers.

@odeimaiz odeimaiz merged commit 4159b89 into ITISFoundation:master Jul 20, 2020
@odeimaiz odeimaiz mentioned this pull request Aug 4, 2020
odeimaiz added a commit that referenced this pull request Aug 4, 2020
- UI/UX improvements (#1657)
- Bump yarl from 1.4.2 to 1.5.1 in /packages/postgres-database (#1665)
- Bump ujson from 3.0.0 to 3.1.0 in /packages/service-library (#1664)
- Bump pytest-docker from 0.7.2 to 0.8.0 in /packages/service-library (#1647)
- Improving storage performance (#1659)
- Bump aiozipkin from 0.6.0 to 0.7.0 in /packages/service-library (#1642)
- Theming (#1656)
- Platform stability:  (#1645)
- is1594 fix and re-activate e2e testing (#1620)
- 2 bugs fixed + Some improvements (#1634)
- Fixes default (#1640)
- Bump lodash from 4.17.15 to 4.17.19 (#1639)
- Is1585/cleanup storage (#1586)
- Fixes on publish studies handling (#1632)
- Some enhancements and bug fixes (#1608)
- Improve e2e  (#1631)
- filter studies by name before deleting them (#1629)
- Maintenance/upgrades test tools (#1628)
- Bugfix/concurent opening projects (#1598)
- Bugfix/allow reading groups anonymous user (#1615)
- Bump docker from 4.2.1 to 4.2.2 in /packages/postgres-database (#1605)
- fix testing if node has gpu support (#1604)
- [bugfix] Invalidate cache before starting a study (#1602)
- Feature/fix e2e 2 (#1600)
- fix deploy not needing e2e testing since it is disabled
- reduce cardinality of metrics (#1593)
- Excudes e2e stage from include until fixed (#1595)
- Shared project concurrency (frontend) (#1591)
- Homogenize studies and services (#1569)
- [feature] UI Fine grained access - project locking and notification
- Bugfix/apiserver does not need sslheaders (#1564)
- Cleanup catalog service (#1582)
- Maintenance/cleanup api server (#1578)
- Adds support for GPU scheduling of computational services (#1553)
- Maintenance/upgrades and tooling (#1546)
- Is1570/study fails 500 (#1572)
- Bump faker from 4.1.0 to 4.1.1 in /packages/postgres-database (#1573)
- maintenance fix codecov reports (#1568)
- Manage groups, Share studies (#1512)
- Is/add notebook migration script (#1565)
- Is1269/api-server upgrade (#1475)
- added simcore_webserver_service in pytest simcore package (#1563)
- add traefik endpoint to api-gateway (#1555)
@odeimaiz odeimaiz deleted the feature/platform_stability_1 branch August 18, 2020 08:48
@sanderegg sanderegg mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants