Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamodeling II + Markers #2966

Merged
merged 35 commits into from
Apr 9, 2022
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 6, 2022

What do these changes do?

  • Show node:port in linked input tooltip
  • "Add probe" button next to output ports
  • Bookmarks can be CRUD to Nodes

Bonus:

  • Show small lock when inputs in a node are locked because they are running

ToolTips in inputs + probes:
Meta

Markers:
Markers

Related issue/s

closes #2950
closes #2952
closes #2953

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Apr 6, 2022
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2966 (a3be2ca) into master (1a9fc15) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2966     +/-   ##
========================================
- Coverage    79.6%   79.5%   -0.1%     
========================================
  Files         681     681             
  Lines       28411   28417      +6     
  Branches     3659    3661      +2     
========================================
+ Hits        22617   22619      +2     
- Misses       5028    5033      +5     
+ Partials      766     765      -1     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 75.2% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls-library/src/models_library/projects_nodes_ui.py 100.0% <100.0%> (ø)
...s/models-library/src/models_library/projects_ui.py 100.0% <100.0%> (ø)
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 78.0% <0.0%> (-2.8%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.4% <0.0%> (-1.6%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 67.2% <0.0%> (-1.3%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 88.0% <0.0%> (ø)
.../director/src/simcore_service_director/producer.py 62.5% <0.0%> (+0.6%) ⬆️
...ore_service_director_v2/utils/dask_client_utils.py 79.1% <0.0%> (+0.8%) ⬆️
... and 2 more

@odeimaiz odeimaiz added this to the a-mile-stone milestone Apr 8, 2022
@odeimaiz odeimaiz changed the title WIP: Metamodeling II Metamodeling II + Markers Apr 8, 2022
@odeimaiz odeimaiz marked this pull request as ready for review April 8, 2022 12:51
@odeimaiz odeimaiz requested review from elisabettai and KZzizzle April 8, 2022 13:14
"WARNING": "orange",
"ERROR": "red"
"INFO": {
color: "ready-green",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you still call it "green"

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice =)

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
3 participants