-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️⬆️ Maintenance/removing pydantic constraints #4065
♻️⬆️ Maintenance/removing pydantic constraints #4065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12008 lines exceeds the maximum allowed for the inline comments feature.
Codecov Report
@@ Coverage Diff @@
## master #4065 +/- ##
=========================================
+ Coverage 85.4% 87.9% +2.4%
=========================================
Files 951 500 -451
Lines 41262 25863 -15399
Branches 957 288 -669
=========================================
- Hits 35260 22741 -12519
+ Misses 5783 3054 -2729
+ Partials 219 68 -151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12024 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12024 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12346 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot for removing this constraint!
As agreed, please let #4066 get merge in master first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12279 lines exceeds the maximum allowed for the inline comments feature.
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit b3fce4c and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we strip the patternProperties and additionalProperties form some placed but add them elsewhere.
These are two different things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
Highlights on updated libraries
autoscaling🧪
simcore-sdk🧪
storage🧪
environment-setup🧪
models-library🧪
service-integration🧪
service-library🧪🧪
settings-library🧪
simcore-sdk🧪
swarm-deploy🧪
autoscaling🧪
simcore-sdk🧪
storage🧪
Related issue/s
How to test