Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️⬆️ Maintenance/removing pydantic constraints #4065

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Apr 5, 2023

What do these changes do?

  • ♻️ Removing pydantic constraints
  • ⬆️ upgrade test & tools dependencies of pydantic

Highlights on updated libraries

  • #packages before: 4
  • #packages after : 1
# name before after upgrade count packages
1 importlib-metadata 6.0.0 🗑️ removed 4 agent🧪
autoscaling🧪
simcore-sdk🧪
storage🧪
2 pydantic 1.10.2 1.10.7 9 dask-task-models-library🧪
environment-setup🧪
models-library🧪
service-integration🧪
service-library🧪🧪
settings-library🧪
simcore-sdk🧪
swarm-deploy🧪
3 typing-extensions 4.5.0 🗑️ removed 1 simcore-sdk🧪
4 zipp 3.15.0 🗑️ removed 4 agent🧪
autoscaling🧪
simcore-sdk🧪
storage🧪

Related issue/s

How to test

@matusdrobuliak66 matusdrobuliak66 self-assigned this Apr 5, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Jelly Beans milestone Apr 5, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12008 lines exceeds the maximum allowed for the inline comments feature.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4065 (b3fce4c) into master (11cfff5) will increase coverage by 2.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4065      +/-   ##
=========================================
+ Coverage    85.4%   87.9%    +2.4%     
=========================================
  Files         951     500     -451     
  Lines       41262   25863   -15399     
  Branches      957     288     -669     
=========================================
- Hits        35260   22741   -12519     
+ Misses       5783    3054    -2729     
+ Partials      219      68     -151     
Flag Coverage Δ
integrationtests 66.6% <100.0%> (-0.1%) ⬇️
unittests 84.0% <100.0%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_webserver/projects/project_models.py 96.6% <100.0%> (+0.2%) ⬆️

... and 467 files with indirect coverage changes

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12024 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12024 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12346 lines exceeds the maximum allowed for the inline comments feature.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review April 6, 2023 07:36
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Apr 6, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Maintenance/removing pydantic constraints ♻️⬆️ Maintenance/removing pydantic constraints Apr 6, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot for removing this constraint!

As agreed, please let #4066 get merge in master first.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12279 lines exceeds the maximum allowed for the inline comments feature.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2023

Code Climate has analyzed commit b3fce4c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we strip the patternProperties and additionalProperties form some placed but add them elsewhere.

@matusdrobuliak66
Copy link
Contributor Author

matusdrobuliak66 commented Apr 6, 2023

I don't understand why we strip the patternProperties and additionalProperties form some placed but add them elsewhere.

These are two different things:

  1. why do we strip them?
  1. why do we add them?
  • Pydantic v 1.0.3 introduced additionalProperties when you create json schema/open api specs from Pydantic model

@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK April 6, 2023 14:04
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66 matusdrobuliak66 merged commit c3652da into ITISFoundation:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change after pydantic version upgrade
4 participants