Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new clone_study in api-server #4663

Merged
merged 16 commits into from
Aug 28, 2023

Conversation

pcrespov
Copy link
Member

What do these changes do?

  • ✨ NEW clone_study as POST /v0/studies/{study_id}:clone
  • 🐛 create_* and clone_* operations respond with 201 Created
  • 🔨 New generic fixture for long-running-tasks

@bisgaard-itis we can now use this feature to clone templates for the tutorial?

Related issue/s

How to test

Driving tests are test_clone_study* in

pytest -vv tests/unit/api_studies/test_api_routes_studies.py

DevOps

None

@pcrespov pcrespov self-assigned this Aug 25, 2023
@pcrespov pcrespov added this to the Baklava milestone Aug 25, 2023
@pcrespov pcrespov added the a:apiserver api-server service label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4663 (5fb2dac) into master (7b0f9a9) will increase coverage by 0.1%.
The diff coverage is 86.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4663     +/-   ##
========================================
+ Coverage    86.6%   86.8%   +0.1%     
========================================
  Files        1055     844    -211     
  Lines       44747   37517   -7230     
  Branches     1020     535    -485     
========================================
- Hits        38786   32568   -6218     
+ Misses       5732    4826    -906     
+ Partials      229     123    -106     
Flag Coverage Δ
integrationtests 65.4% <ø> (+0.4%) ⬆️
unittests 83.9% <86.6%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...library/src/servicelib/long_running_tasks/_task.py 95.2% <ø> (ø)
...core_service_api_server/api/routes/studies_jobs.py 59.2% <ø> (ø)
...ervice_api_server/api/errors/httpx_client_error.py 44.4% <25.0%> (-2.7%) ⬇️
...c/simcore_service_api_server/services/webserver.py 87.6% <94.5%> (-1.6%) ⬇️
...brary/src/servicelib/long_running_tasks/_models.py 100.0% <100.0%> (ø)
...core_service_api_server/api/routes/solvers_jobs.py 76.1% <100.0%> (ø)
...c/simcore_service_api_server/api/routes/studies.py 100.0% <100.0%> (+4.8%) ⬆️
...ver/src/simcore_service_api_server/models/types.py 100.0% <100.0%> (ø)

... and 220 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review August 25, 2023 15:53
@pcrespov pcrespov force-pushed the is4651/clone-study branch from 324b9ed to 5e7dea1 Compare August 25, 2023 17:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2023

Code Climate has analyzed commit 5fb2dac and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov requested a review from bisgaard-itis August 25, 2023 19:12
@pcrespov pcrespov enabled auto-merge (squash) August 25, 2023 19:12
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, my only concern here is whether that actually works when there are multiple webserver instances??

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studies API: Add public API entrypoint to clone studies
4 participants