-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ new clone_study
in api-server
#4663
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
========================================
+ Coverage 86.6% 86.8% +0.1%
========================================
Files 1055 844 -211
Lines 44747 37517 -7230
Branches 1020 535 -485
========================================
- Hits 38786 32568 -6218
+ Misses 5732 4826 -906
+ Partials 229 123 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
|
324b9ed
to
5e7dea1
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 5fb2dac and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, my only concern here is whether that actually works when there are multiple webserver instances??
services/api-server/src/simcore_service_api_server/services/webserver.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks for adding this.
What do these changes do?
clone_study
asPOST /v0/studies/{study_id}:clone
create_*
andclone_*
operations respond with201 Created
@bisgaard-itis we can now use this feature to clone templates for the tutorial?
Related issue/s
How to test
Driving tests are
test_clone_study*
inDevOps
None