Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ WIP: Is4652/job logs stream #4665

Closed
wants to merge 13 commits into from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 25, 2023

What do these changes do?

A first iteration on job logs streaming.

  • common functionality of rabbit?
  • api-server now interact with rabbit service
  • services/api-server/tests/unit/test_services_rabbitmq.py to test how logs can be captured
  • services/api-server/tests/unit/api_solvers/test_api_routers_solvers_jobs_logs.py to draft how logs a

Related issue/s

How to test

Driving test services/api-server/tests/unit/api_solvers/test_api_routers_solvers_jobs_logs.py

DevOps

None

@pcrespov pcrespov self-assigned this Aug 25, 2023
@pcrespov pcrespov added this to the Baklava milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4665 (e39c030) into master (633ec55) will decrease coverage by 1.9%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4665     +/-   ##
========================================
- Coverage    87.2%   85.4%   -1.9%     
========================================
  Files        1252    1029    -223     
  Lines       51339   44134   -7205     
  Branches     1107     747    -360     
========================================
- Hits        44790   37696   -7094     
+ Misses       6310    6279     -31     
+ Partials      239     159     -80     
Flag Coverage Δ
integrationtests 63.6% <100.0%> (-1.4%) ⬇️
unittests 85.1% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ice_webserver/notifications/_rabbitmq_consumers.py 63.9% <100.0%> (-26.3%) ⬇️

... and 294 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4652/job-logs-stream branch from cb8b348 to 025afb1 Compare September 8, 2023 09:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@pcrespov pcrespov force-pushed the is4652/job-logs-stream branch from e9ca8ae to e39c030 Compare November 16, 2023 01:01
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

Copy link

codeclimate bot commented Nov 16, 2023

Code Climate has analyzed commit e39c030 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov
Copy link
Member Author

pcrespov commented Nov 20, 2023

@pcrespov pcrespov closed this Nov 20, 2023
@pcrespov pcrespov deleted the is4652/job-logs-stream branch November 20, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant