🎨 Job log streaming: connect endpoint with rabbitMQ #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
approved these changes
Nov 20, 2023
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Great job.
Few suggestions/comments:
- the imports in servicelib are definitively wrong. Probably auto imports that got in there. It is not allowed to import services into libraries (the opposite is true)
- would separate this in two PRs. one with changes in rabbitmq and then the actual feature (if time permits)
pcrespov
approved these changes
Nov 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 11cd7a0 and detected 0 issues on this pull request. View more on Code Climate. |
matusdrobuliak66
approved these changes
Nov 21, 2023
This was referenced Nov 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev Checklist
DevOps Checklist
None