Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Read-only user cannot open the iframes #5048

Merged
merged 3 commits into from
Nov 20, 2023
Merged

🐛 Read-only user cannot open the iframes #5048

merged 3 commits into from
Nov 20, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Nov 20, 2023 •
edited by pcrespov
Loading

What do these changes do?

The issue is because if a user doesn't have access to the project wallet the button is disabled as it didn't fall back to the users default/preferred wallet.

2023-11-20 08 57 25

Related issue/s

How to test

  1. Create a user
  2. From another user share a project with the new user and make the user read only for that project
  3. As the new user try access the project

PASS: If the issue is fixed the user should be able to enter the project without issue
FAIL: The new user is unable to enter the project

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 added this to the 7peaks milestone Nov 20, 2023
@jsaq007 jsaq007 self-assigned this Nov 20, 2023
@jsaq007 jsaq007 requested a review from ignapas as a code owner November 20, 2023 07:58
@jsaq007 jsaq007 enabled auto-merge (squash) November 20, 2023 08:00
@jsaq007 jsaq007 requested a review from GitHK November 20, 2023 08:01
sanderegg
sanderegg approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

elisabettai
elisabettai approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pcrespov
pcrespov approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx Julien. I took the liberty to add the issue link in the corresponding section.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit 84e394f and detected 0 issues on this pull request.

View more on Code Climate.

@jsaq007 jsaq007 merged commit c12b6c7 into ITISFoundation:master Nov 20, 2023
49 checks passed
This was referenced Nov 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@jsaq007 jsaq007

Labels
None yet
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.

Read-only user cannot open the iframes
7 participants
@jsaq007 @ignapas @GitHK @elisabettai @pcrespov @sanderegg @matusdrobuliak66