Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 UI updates - 🐛 bug fixes #5111

Merged
merged 16 commits into from
Dec 12, 2023
Merged

🎨 UI updates - 🐛 bug fixes #5111

merged 16 commits into from
Dec 12, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Nov 30, 2023 •
edited by elisabettai
Loading

What do these changes do?

🎨 UI updates
Button and color updates - (This will be ongoing. I still want to handle the input fields and other colours as things progress)

🐛 bug fixes

Dashboard new design: small refinements

  1. Hovering on sharing at the bottom of the page is trimmed - Added space at the bottom
  2. Tutorials tab, it seems that the user is selecting something - Fixed the problem
  3. Click to select project is a bit broken - Needs a proper solution
  4. Remove "Dashboard" text when it is not actionable - Done

2023-12-05 10 46 24
2023-12-05 10 47 12

Related issue/s

o²S²PARC UX/UI Improvements #1083 ?
fixes Dashboard new design: small refinements #5086

How to test

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) UI/UX labels Nov 30, 2023
@jsaq007 jsaq007 self-assigned this Nov 30, 2023
@jsaq007 jsaq007 added this to the Kobayashi Maru milestone Nov 30, 2023
ignapas
ignapas reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of comments, I could not actually try the thing yet

services/static-webserver/client/source/class/osparc/dashboard/GridButtonItem.js Outdated Show resolved Hide resolved
services/static-webserver/client/source/class/osparc/navigation/NavigationBar.js Outdated Show resolved Hide resolved
@ignapas
Copy link
Contributor

ignapas commented Nov 30, 2023

can we use a blue checkmark (in the last screenshot) instead of black

elisabettai
elisabettai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and in my opinion it fixes the linked issue.

There's only the "Click to select project is a bit broken" that needs a proper fix, as far as I understand, but maybe it is not too critical. Where you thinking to fix that in another PR at some point?

sanderegg
sanderegg reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jsaq007
Copy link
Contributor Author

jsaq007 commented Dec 5, 2023

can we use a blue checkmark (in the last screenshot) instead of black

@ignapas The blue circle was intended to properly show it as selected. Would you be OK with this till other feedback comes in?

@jsaq007 jsaq007 requested a review from ignapas December 5, 2023 16:51
@ignapas
Copy link
Contributor

ignapas commented Dec 6, 2023

Is this still a draft? Let me know when I should review. Thanks.

@jsaq007 jsaq007 marked this pull request as ready for review December 6, 2023 10:45
@jsaq007
Copy link
Contributor Author

jsaq007 commented Dec 6, 2023

Is this still a draft? Let me know when I should review. Thanks.

Sorry forgot to update the PR :)

ignapas
ignapas reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, already an amazing improvement!
Just a couple of minor details, I guess not "musts" but I think would be nice to get in with the rest:

In the light mode

  • When hovering some buttons, the text/icons have almost no contrast

Screenshot from 2023-12-07 15-28-39
Screenshot from 2023-12-07 15-27-40
Screenshot from 2023-12-07 15-30-12

And that's it! Thanks a lot...

@jsaq007
Copy link
Contributor Author

jsaq007 commented Dec 11, 2023

This is looking great, already an amazing improvement! Just a couple of minor details, I guess not "musts" but I think would be nice to get in with the rest:

In the light mode

  • When hovering some buttons, the text/icons have almost no contrast

Screenshot from 2023-12-07 15-28-39 Screenshot from 2023-12-07 15-27-40 Screenshot from 2023-12-07 15-30-12

And that's it! Thanks a lot...

Hi @ignapas these should be handled a little better?

Screenshot 2023-12-11 at 09 54 39 Screenshot 2023-12-11 at 09 55 14 Screenshot 2023-12-11 at 09 55 22

@elisabettai I also handle the submit service button in here as I missed in my previous PR
https://app.marker.io/i/6565d3d3b40e96cdb74e9d5b_532944bf9137aca0?activePane=issue
Screenshot 2023-12-11 at 09 58 04

@jsaq007 jsaq007 requested a review from ignapas December 11, 2023 10:20
ignapas
ignapas approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jsaq007 jsaq007 enabled auto-merge (squash) December 12, 2023 11:26
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 2d32d93 and detected 0 issues on this pull request.

View more on Code Climate.

@jsaq007 jsaq007 merged commit 09dd712 into ITISFoundation:master Dec 12, 2023
49 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 12, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@ignapas ignapas ignapas approved these changes

@elisabettai elisabettai elisabettai approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@eofli eofli Awaiting requested review from eofli

@cosfor1 cosfor1 Awaiting requested review from cosfor1

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@jsaq007 jsaq007

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected UI/UX
Projects
None yet
Milestone
Kobayashi Maru
Development

Successfully merging this pull request may close these issues.

Dashboard new design: small refinements
5 participants
@jsaq007 @ignapas @elisabettai @sanderegg @matusdrobuliak66