Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨⚗️Comp backend/bugfix/work stealing (⚠️ devops) #5261

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 22, 2024

What do these changes do?

As noted while testing, there are some cases where the dask-workers are not balancing the workload optimally.
As explained in the dask-distributed documentation, the queue of each worker may be adjusted by changing the number of threads a worker provides and/or the worker-saturation. Since the first one is easily changeable, this PR allows to do just that.
In a billable product where 1 machine can run 1 job it also does not really make sense to provide more than 1 thread per worker.

Therefore a new ENV is introduced at the clusters-keeper service level.

Bonus:

  • improvements to e2e playwright code in general and for the sleepers in particular

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added e2e Bugs found by or related to the end-2-end testing a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Jan 22, 2024
@sanderegg sanderegg added this to the This is Sparta! milestone Jan 22, 2024
@sanderegg sanderegg self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed71fd7) 81.9% compared to head (c14c0a1) 87.3%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5261      +/-   ##
=========================================
+ Coverage    81.9%   87.3%    +5.4%     
=========================================
  Files         394    1302     +908     
  Lines       14367   53251   +38884     
  Branches      381    1167     +786     
=========================================
+ Hits        11767   46491   +34724     
- Misses       2528    6511    +3983     
- Partials       72     249     +177     
Flag Coverage Δ
integrationtests 65.0% <ø> (?)
unittests 85.1% <100.0%> (+3.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/simcore_service_clusters_keeper/core/settings.py 95.8% <100.0%> (ø)
.../simcore_service_clusters_keeper/utils/clusters.py 75.0% <ø> (ø)

... and 909 files with indirect coverage changes

@sanderegg sanderegg force-pushed the comp-backend/bugfix/work-stealing branch from 09ee122 to ce3f9c1 Compare January 22, 2024 21:56
@sanderegg sanderegg marked this pull request as ready for review January 22, 2024 22:01
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg changed the title 🎨Comp backend/bugfix/work stealing 🎨Comp backend/bugfix/work stealing (⚠️ devops) Jan 22, 2024
@sanderegg sanderegg changed the title 🎨Comp backend/bugfix/work stealing (⚠️ devops) 🎨⚗️Comp backend/bugfix/work stealing (⚠️ devops) Jan 22, 2024
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new ENV safe? Can we merge it immediately for all deployments?

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg
Copy link
Member Author

Is the new ENV safe? Can we merge it immediately for all deployments?

@YuryHrytsuk : I am not sure why it would not be safe. it is an addition, so yes it is fully safe or am I missing something there?

@YuryHrytsuk
Copy link
Contributor

Is the new ENV safe? Can we merge it immediately for all deployments?

@YuryHrytsuk : I am not sure why it would not be safe. it is an addition, so yes it is fully safe or am I missing something there?

No worries. I am asking because I don't know

@YuryHrytsuk YuryHrytsuk self-requested a review January 23, 2024 07:47
@sanderegg sanderegg merged commit 4f136a0 into ITISFoundation:master Jan 23, 2024
55 checks passed
@sanderegg sanderegg deleted the comp-backend/bugfix/work-stealing branch January 23, 2024 07:51
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants