Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛🎨 Fix backenderror name injection #6064

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 15, 2024

What do these changes do?

  • Check that keyword arguments to backend clients match the exceptions to which http status errors are mapped.
  • Fix a bug detected by this new mechanism.
  • Add https://github.com/r1chardj0n3s/parse as a dependency to api-server in order to parse inputs to f string template.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Jul 15, 2024
@bisgaard-itis bisgaard-itis added this to the Tom Bombadil milestone Jul 15, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review July 15, 2024 14:05
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner July 15, 2024 14:05
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (cafbf96) to head (7bc557b).
Report is 345 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6064      +/-   ##
=========================================
- Coverage    84.5%   66.9%   -17.6%     
=========================================
  Files          10     641     +631     
  Lines         214   31297   +31083     
  Branches       25     205     +180     
=========================================
+ Hits          181   20967   +20786     
- Misses         23   10279   +10256     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 89.8% <100.0%> (+5.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re_service_api_server/exceptions/backend_errors.py 100.0% <100.0%> (ø)
...vice_api_server/exceptions/service_errors_utils.py 88.7% <100.0%> (ø)

... and 649 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice trick to prevent errors
thx

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 16, 2024 07:45
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bisgaard-itis bisgaard-itis merged commit 850c52b into ITISFoundation:master Jul 16, 2024
56 checks passed
@bisgaard-itis bisgaard-itis deleted the 6056-fix-backenderror-name-injection branch July 16, 2024 08:38
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure inputs to BaseBackendError are available when thrown
3 participants