-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes unhandled KeyError
when missing keys in exception's msg_template
#6188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6188 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.4%
=========================================
Files 10 1315 +1305
Lines 214 57071 +56857
Branches 25 1132 +1107
=========================================
+ Hits 181 50261 +50080
- Misses 23 6564 +6541
- Partials 10 246 +236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
59b631b
to
f1be1ae
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Addresses this error found in tip.science deploy
The api-server responds 500 to
GET /v2/computations/ ...
instead of 404 (in this case) due to an unhandled errorDetails
test_oec_139646582688800_missing_ctx_values_for_msg_template
OsparcErrorMixin.__str__
to avoid raisingKeyError
when key is missing in template error messages. The message will include a default placeholder instead of raising and stopping executionRelated issue/s
How to test
services/api-server/tests/unit/test_services_directorv2.py
reproduces log reportDev-ops checklist