♻️ Replace r clone ⚠️🚨

[matusdrobuliak66]

What do these changes do?

• ♻️ Replace RClone with AWS CLI.
• RClone functionality is still supported and can be turned on or off with AWS_S3_CLI_S3 env variable. If provided then AWS S3 CLI is prefered before RClone.
• I tried to be as consistent with the RClone interface as possible.
  • I needed to handle symlinks manually, as AWS CLI doesn't have that option like RClone does.

Related issue/s

• relates Replace RClone sync by AWS CLI sync #5833
• relates Testing with RClone #5828

How to test

Dev-ops checklist

• ⚠️ new variable AWS_S3_CLI_S3
  • https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/754
• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 87.21461% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.5%. Comparing base (cafbf96) to head (9fbc179).
Report is 397 commits behind head on master.

Files	Patch %	Lines
...dk/src/simcore_sdk/node_ports_common/aws_s3_cli.py	90.0%	9 Missing and 5 partials ⚠️
...k/src/simcore_sdk/node_ports_common/filemanager.py	44.0%	8 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6119      +/-   ##
=========================================
+ Coverage    84.5%   87.5%    +2.9%     
=========================================
  Files          10    1460    +1450     
  Lines         214   60337   +60123     
  Branches       25    1475    +1450     
=========================================
+ Hits          181   52796   +52615     
- Misses         23    7230    +7207     
- Partials       10     311     +301     

Flag	Coverage Δ
integrationtests	60.7% <85.3%> (?)
unittests	86.0% <41.0%> (+1.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ettings-library/src/settings_library/aws_s3_cli.py	100.0% <100.0%> (ø)
...core-sdk/src/simcore_sdk/node_data/data_manager.py	73.3% <100.0%> (ø)
...re-sdk/src/simcore_sdk/node_ports_common/_utils.py	100.0% <100.0%> (ø)
.../simcore_sdk/node_ports_common/aws_s3_cli_utils.py	100.0% <100.0%> (ø)
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py	98.1% <100.0%> (ø)
...src/simcore_sdk/node_ports_common/r_clone_utils.py	100.0% <100.0%> (ø)
...core-sdk/src/simcore_sdk/node_ports_v2/__init__.py	100.0% <100.0%> (ø)
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py	93.2% <100.0%> (ø)
.../simcore-sdk/src/simcore_sdk/node_ports_v2/port.py	79.8% <ø> (ø)
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py	69.0% <100.0%> (ø)
... and 9 more

... and 1397 files with indirect coverage changes

[GitHK]

Looks good, please see my last comments, especially the "if else assert" part. I'd prefer an error to be raised, which is more explicit than an assert which is stripped in production. This will make releases more simpler, fi the configuration is wrong.

[GitHK]

@matusdrobuliak66 please don't forget to add an MR with the env changes to this PR

[sanderegg]

very cool! thanks for the changes!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud