Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Touch screen support #6178

Merged
merged 11 commits into from
Aug 26, 2024
Merged

✨ Touch screen support #6178

merged 11 commits into from
Aug 26, 2024

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Aug 13, 2024 •
edited
Loading

What do these changes do?

Start of making osparc a progressive web app

  • enables standalone
  • distinguishes between the various app (osparc, s4l and TIP)
  • add icon for local fallback if needed else creates the manifest by getting the icons from github assets

IMG_0002

IMG_0001

RPReplay_Final1723532825.mov

Related issue/s

How to test

Dev-ops checklist

@jsaq007 jsaq007 added a:frontend issue affecting the front-end (area group) UI/UX labels Aug 13, 2024
@jsaq007 jsaq007 added this to the Tom Bombadil milestone Aug 13, 2024
@jsaq007 jsaq007 self-assigned this Aug 13, 2024
sanderegg
sanderegg reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/e2e-frontend/playwright.config.js Show resolved Hide resolved
@ignapas
Copy link
Contributor

ignapas commented Aug 13, 2024

can I get a private show of this? 🙏🏼

pcrespov
pcrespov reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

odeimaiz
odeimaiz reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the other product icons?

@jsaq007 jsaq007 requested review from pcrespov and odeimaiz August 14, 2024 11:45
odeimaiz
odeimaiz requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The favicon you are using for s4l is not the same as the current favicon, you are missing the border. Please do not touch the favicons if you don't want to end up in a endless email exchange.

And test that ALL products (favicon, title, description) work as before.

pcrespov
pcrespov reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

sanderegg
sanderegg reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 cool!

pcrespov
pcrespov reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrnicegyu11 mrnicegyu11 changed the title Touch screen support ✨ Touch screen support Aug 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jsaq007 jsaq007 enabled auto-merge (squash) August 26, 2024 13:05
@jsaq007 jsaq007 merged commit 857dda9 into ITISFoundation:master Aug 26, 2024
50 checks passed
This was referenced Sep 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@elisabettai elisabettai Awaiting requested review from elisabettai

@mguidon mguidon Awaiting requested review from mguidon

@eofli eofli Awaiting requested review from eofli

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@jsaq007 jsaq007

Labels
a:frontend issue affecting the front-end (area group) UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifest File: Installable on Home Screen:
6 participants
@jsaq007 @ignapas @pcrespov @odeimaiz @sanderegg @matusdrobuliak66