Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web2 DB mix-up #14

Merged
merged 3 commits into from
Jul 4, 2016
Merged

Fix web2 DB mix-up #14

merged 3 commits into from
Jul 4, 2016

Conversation

rbu
Copy link
Contributor

@rbu rbu commented Apr 28, 2016

This was probably broken by the variable rename in 805c25d

@rbu
Create Web and IDO database seperately in web2
9c50df9 
This cleans up the mix between IDO and icingaweb users and database,
where previously it would create an IDO database and import the web2
schema.
Also, privileges were incorrectly set on the username instead of the
db name (which just happened to be the same by default).
@rbu rbu changed the title Fix web2 variable name references Fix web2 DB mix-up Apr 28, 2016
@rbu
Copy link
Contributor Author

rbu commented Apr 28, 2016

I've updated the PR. There was a mixup between IDO and web2 database. I'd like to do more cleanup here, but I'd be interested if you would merge it before putting in the effort. Specifically:

  • IDO configuration is duplicated between web2 and web (and incorrect in web), I'd like to factor that out into a role which is a dependency
  • The ido template should really be a template instead of having to be provided by the user
  • There are two readmes (one in web2 and one in docs) which seem duplicated

@tduemesnil
Copy link

Thanks for that fix. Helped me out when writing the script for Debian.

@icingaadmin icingaadmin merged commit c28792e into Icinga:master Jul 4, 2016
diegocarrion-wk pushed a commit to Workiva/icinga2-ansible that referenced this pull request May 7, 2019
@kareemstraker-wk @diegocarrion-wk
# This is a combination of 20 commits.
174645d 
# This is the 1st commit message:

add pinned versions for apt icinga

# This is the commit message #2:

reordering dependencies

# This is the commit message #3:

fix merge conflict 5500188

# This is the commit message #4:

remove duplicates, set final order

# This is the commit message #5:

updated descriptions and cleanup

# This is the commit message #6:

externalise icinga2_version

# This is the commit message #7:

update pyOpenSSL to be build on xenial

# This is the commit message #8:

add alternative way to add apt keys

# This is the commit message #9:

ignore errors

# This is the commit message Icinga#10:

update ubuntu install

# This is the commit message Icinga#11:

fix syntax

# This is the commit message Icinga#12:

try new urllib version

# This is the commit message Icinga#13:

remove urllib3 install

# This is the commit message Icinga#14:

use .com repos

# This is the commit message Icinga#15:

remove debmon stuff

# This is the commit message Icinga#16:

fix dependencies version pin

# This is the commit message Icinga#17:

remove replaced package

# This is the commit message Icinga#18:

pin another package

# This is the commit message Icinga#19:

undo change

# This is the commit message Icinga#20:

add icinga2-ido-mysql to pinned versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbu @tduemesnil @icingaadmin