This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
Update packages to build icinga2 on Ubuntu Xenial #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
kareemstraker-wk
approved these changes
Jun 5, 2018
|
+1 lgtm |
|
lgtm |
cristianmartinello-wf
force-pushed
the
fix_build_issues_on_xenial2
branch
from
1e1c9fa to
fb0ad4d
Compare
|
@kareemstraker-wk @diegocarrion-wk do you mind to take another look at this? so I can get rid of this change here: https://github.com/Workiva/icinga2-cf/pull/27/files#diff-26cbb55d2304944f7fcfb0c840194664R47 |
| @@ -2,15 +2,15 @@ | |||
| - name: install urllib3 | |||
| pip: | |||
| name: urllib3 | |||
| version: 1.7.1 | |||
| version: 1.22 | |||
There was a problem hiding this comment.
Have you tested this recently? Yesterday on one of the iterations of the icinga machines this was causing ansible failures because 1.22 could not be found (only 1.21 and 1.23)
|
+1 lgtm |
|
lgtm |
diegocarrion-wk
approved these changes
Jul 9, 2018
diegocarrion-wk
pushed a commit
that referenced
this pull request
May 7, 2019
# This is the 1st commit message: add pinned versions for apt icinga # This is the commit message #2: reordering dependencies # This is the commit message #3: fix merge conflict 5500188 # This is the commit message #4: remove duplicates, set final order # This is the commit message #5: updated descriptions and cleanup # This is the commit message #6: externalise icinga2_version # This is the commit message #7: update pyOpenSSL to be build on xenial # This is the commit message #8: add alternative way to add apt keys # This is the commit message #9: ignore errors # This is the commit message Icinga#10: update ubuntu install # This is the commit message Icinga#11: fix syntax # This is the commit message Icinga#12: try new urllib version # This is the commit message Icinga#13: remove urllib3 install # This is the commit message Icinga#14: use .com repos # This is the commit message Icinga#15: remove debmon stuff # This is the commit message Icinga#16: fix dependencies version pin # This is the commit message Icinga#17: remove replaced package # This is the commit message Icinga#18: pin another package # This is the commit message Icinga#19: undo change # This is the commit message Icinga#20: add icinga2-ido-mysql to pinned versions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new AMI based on Ubuntu Xenial we have to upgrade few packages otherwise they will not build.
@Workiva/sre