Introduce ScheduleElement

[yhabteab]

No description provided.

[yhabteab]

Blocked by

• Replace SubFormElement with FieldsetElement ipl-html#74
• FormElement: Add RadioElement ipl-html#68

[flourish86]

I’m not sure, if this is a bug, but the occurences are displayed wrong or not set correctly:
Also the seconds seem to be ignored.

The occurences should be 16:25:37, 16:26:37, 16:27:37

Analogous are the other regular ones.

[flourish86]

• Please preselect the option “Each” here and accordingly disable the inputs for the one, that is not selected.
  

• Also for annually …
  

• Besides that, either remove or enable the “Every” field.

But all in all it already looks pretty good. Thanks so far.

[yhabteab]

I’m not sure, if this is a bug, but the occurences are displayed wrong or not set correctly:

You need to checkout this branch as well. Icinga/ipl-scheduler#12

Also the seconds seem to be ignored.

That's to be expected!

[nilmerg]

Additionally:

• Please use the LESS variables of this library, not these by Icinga Web
• Avoid unnecessary specificity
  • If unavoidable, keep the ruleset compact and put other rules (e.g. style) in less specific rulesets

[yhabteab]

I don’t know why but when using @base-disabled instead of @disabled-gray as a text color doesn’t seem to work.

[nilmerg]

I don't know as well, but if you take a look at the notice at the start of variables.less you can see you shouldn't use this directly anyway.

[flourish86]

• Please also change the occurences layout.

Having 3 occurences listed is also a lot less clear. While it makes sense for the custom options, it doesn’t for the less complex non custom ones.

• So let’s strip them away for the non-custom ones and show only one occurence, since this is perfectly sufficient.

• It would also make it more clear, to highlight the exact pieces of information, that are important, so it’s easier to grasp the difference.

[flourish86]

I’m not sure about the markup here, since it’s not valid html having different items than li in a ul, see here "Permitted content“ https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul.

I think it’s totally possible to do it like this.

<ul>
  <li>
    <label>
      <input type=“checkbox”>
      …
    <label>
  </li>
…
</ul>

[bobapple]

@cla-bot check

[nilmerg]

Please take a look at the tests. They fail for another reason now.

[nilmerg]

Please allow configuration of id protection by an attribute, just like you did internally.

[nilmerg]

LGTM!

Should not be merged until Icinga/ipl-scheduler#25 is merged.