Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw descriptive error when filtering without condition - 7.3.x #4900

Merged
merged 21 commits into from
Jun 10, 2019
Merged

Throw descriptive error when filtering without condition - 7.3.x #4900

merged 21 commits into from
Jun 10, 2019

Conversation

tachojelev
Copy link
Contributor

@tachojelev tachojelev commented May 28, 2019 •
edited
Loading

#4897

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev tachojelev requested review from bkulov and kdinev May 30, 2019 08:11
@tachojelev tachojelev requested a review from bkulov June 4, 2019 11:41
bkulov
bkulov previously approved these changes Jun 4, 2019
View reviewed changes
@DiyanDimitrov DiyanDimitrov self-requested a review June 5, 2019 08:44
DiyanDimitrov
DiyanDimitrov previously approved these changes Jun 5, 2019
View reviewed changes
@tachojelev tachojelev dismissed stale reviews from DiyanDimitrov and bkulov via 5f81f3f June 6, 2019 10:35
@tachojelev tachojelev requested a review from kdinev June 6, 2019 10:38
@astaev astaev added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 10, 2019
@astaev astaev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 10, 2019
@kdinev kdinev merged commit 3e1d12e into 7.3.x Jun 10, 2019
@kdinev kdinev deleted the tzhelev/fix-4897-7.3.x branch June 10, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@bkulov bkulov bkulov approved these changes

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

@DiyanDimitrov DiyanDimitrov Awaiting requested review from DiyanDimitrov

Assignees

@astaev astaev

Labels
filtering grid: general grid: global-filtering version: 7.3.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tachojelev @kdinev @bkulov @DiyanDimitrov @astaev @gedinakova