Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no condition is provided, filter() method of grid throws undescriptive error #4897

Closed
tachojelev opened this issue May 28, 2019 · 0 comments · Fixed by #5033
Closed
Assignees
Labels
🐛 bug Any issue that describes a bug filtering 🔥 severity: high grid: general grid: global-filtering version: 7.2.x version: 7.3.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@tachojelev
Copy link
Contributor

Description

When no condition is provided, filter() method of grid throws undescriptive error.
When no condition is provided, the filterGlobal() on the other hand does nothing and does not throw error.

  • igniteui-angular version: 7.2.x, 7.3.x
  • browser: any

Steps to reproduce

  1. Add the following lines to the grid-search.sample.html and the grid-search.sample.ts respectively:
<button (click)="test()">test</button>
test() {        
    this.grid1.filter('CompanyName', 'al');
}
  1. Run the "Grid Search" dev demo.
  2. Click the "test" button.

Result

Undescriptive error is thrown.

Expected result

Descriptive error is thrown for both the filter and filterGlobal methods.

Attachments

image

@tachojelev tachojelev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels May 28, 2019
@tachojelev tachojelev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels May 28, 2019
tachojelev added a commit that referenced this issue May 30, 2019
tachojelev added a commit that referenced this issue May 31, 2019
tachojelev added a commit that referenced this issue Jun 4, 2019
tachojelev added a commit that referenced this issue Jun 4, 2019
tachojelev added a commit that referenced this issue Jun 7, 2019
tachojelev added a commit that referenced this issue Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug filtering 🔥 severity: high grid: general grid: global-filtering version: 7.2.x version: 7.3.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants