Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labels feature and refactoring SLIDER #4994

Merged
merged 6 commits into from
Jun 7, 2019
Merged

labels feature and refactoring SLIDER #4994

merged 6 commits into from
Jun 7, 2019

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Jun 5, 2019 •
edited
Loading

Closes #3449
Closes #4562
Closes #4559
Closes #2622

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr Aleksandyr requested review from zdrawku and nrobakova June 5, 2019 14:41
@Aleksandyr
Copy link
Contributor Author

API documentation should be updated.

@Aleksandyr Aleksandyr changed the title merge slider labels feature labels feature and refactoring SLIDER Jun 5, 2019
@Aleksandyr Aleksandyr added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ do not merge ❌ status: awaiting-test PRs awaiting manual verification labels Jun 6, 2019
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification labels Jun 6, 2019
zdrawku
zdrawku reviewed Jun 6, 2019
View reviewed changes
projects/igniteui-angular/src/lib/slider/slider.component.ts
* ```
*/
public get context(): any {
return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please introduce a new type/interface - Example. Using of Anonymous objects is not a good practice.

zdrawku
zdrawku requested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@zdrawku zdrawku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this change to the other two PRs. Everything else looks great, good job! :)

@nrobakova nrobakova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 6, 2019
zdrawku
zdrawku approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@zdrawku zdrawku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used as a context object, so there is no need to define an Interface for it.

@zdrawku zdrawku merged commit 0c2d73c into master Jun 7, 2019
@zdrawku zdrawku deleted the slider-labels-feature-master branch June 7, 2019 09:50
@Aleksandyr Aleksandyr mentioned this pull request Dec 2, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@nrobakova nrobakova nrobakova approved these changes

Assignees
No one assigned
Labels
feature refactoring slider version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
3 participants
@Aleksandyr @zdrawku @nrobakova