Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw descriptive error when filtering without condition - master #5033

Merged
merged 6 commits into from
Jun 19, 2019
Merged

Throw descriptive error when filtering without condition - master #5033

merged 6 commits into from
Jun 19, 2019

Conversation

tachojelev
Copy link
Contributor

@tachojelev tachojelev commented Jun 10, 2019 •
edited
Loading

Closes #4897

This PR should be merged once the update to Angular 8 is merged to master.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

bkulov
bkulov reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@bkulov bkulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't containg the Changlog.md changes.

@tachojelev
Copy link
Contributor Author

This PR doesn't containg the Changlog.md changes.

Addressed.

bkulov
bkulov previously approved these changes Jun 10, 2019
View reviewed changes
@astaev astaev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 19, 2019
@zdrawku zdrawku merged commit 9d66c9a into master Jun 19, 2019
@zdrawku zdrawku deleted the tzhelev/fix-4897-master branch June 19, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkulov bkulov bkulov approved these changes

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@astaev astaev

Labels
filtering grid: general grid: global-filtering version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When no condition is provided, filter() method of grid throws undescriptive error
6 participants
@tachojelev @bkulov @DiyanDimitrov @zdrawku @astaev @gedinakova